[#40051] - [4.3] Codemirror corrects path for keybinding script +(obey debug - versioning)
- Fixed in Code Base
- 8 May 2023
- Medium
- Build: 4.2-dev
- # 40051
- Diff
- dgrammatiko:patch-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40049 .
Summary of Changes
Testing Instructions
- make codemirror the default browser
- Enable keymaping
- Check that codemirro and keybinding work
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40051.
@brianteeman I just realised that the script is not versioned (it cannot be invalidated if there's a new version) and it's easier to patch this here than opening a new PR. If that's not ok I will revert the last commit
I always prefer one pr per task but its your pr so its your choice. I just ask that if you keep the media version stuff that you update the title and the test instructions please.
| Title |
|
||||||
Call to a member function getDocument() on null
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40051.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40051.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40051.
This pull request has been automatically rebased to 4.3-dev.
Hello Dimitris @dgrammatiko. Do you mind checking the conflict?
| Labels |
Added:
?
bug
|
||
| Labels |
Added:
PR-4.3-dev
|
||
@obuisard done
Thanks Dimitris @dgrammatiko , appreciated!
@Quy or Vio @viocassel, could any of you give it another test as this PR has been re-based from 4.2 to 4.3 and the code moved around under the new structure for plugins. Thank you!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40051.
| Labels |
Removed:
?
|
||
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-08 14:10:53 |
| Closed_By | ⇒ | obuisard |
Thank you Dimitris @dgrammatiko and testers!
This only partially works. The js needs to be updated as well