? bug ? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
7 Mar 2023

Write the field type different to fix issue #38705

Pull Request for Issue #38705 .

Summary of Changes

Changed the field Name, maybe because of Case Sensitive Servers?

Testing Instructions

If you experience that you have no Module Position selectable in the com_user Settings for Multifactor authentification like descriped here: #38705
Apply the patch and see if the module Positions are listed now.

Actual result BEFORE applying this Pull Request

No module positions are shown

Expected result AFTER applying this Pull Request

Module Positions are shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2023
Category Administration com_users
avatar coolcat-creations coolcat-creations - open - 7 Mar 2023
avatar coolcat-creations coolcat-creations - change - 7 Mar 2023
Status New Pending
avatar richard67 richard67 - change - 7 Mar 2023
The description was changed
avatar richard67 richard67 - edited - 7 Mar 2023
avatar richard67
richard67 - comment - 7 Mar 2023

Hmm according to this documentation it should be "moduleposition", lowercase but with singular "module" and not plural "modules": https://docs.joomla.org/ModulePosition_form_field_type

And in the form fields there is also no file with "modules" in plural, only this one: https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Form/Field/ModulepositionField.php

@coolcat-creations What happens if you change type="modulesposition" to type="moduleposition" in the XML file?

avatar coolcat-creations
coolcat-creations - comment - 7 Mar 2023

Then still no Modules are shown in the list:
grafik

avatar richard67
richard67 - comment - 7 Mar 2023

Strange … maybe I’m missing something here.

avatar brianteeman
brianteeman - comment - 7 Mar 2023

did you already try what I had said #38705 (comment)

avatar brianteeman
brianteeman - comment - 7 Mar 2023

Just to be complete - here is a recording of what I explained on the original issue.
The behaviour is exactly the same with and without this PR

It is the intended behaviour of this field to only show positions that are in use. Exactly as you will see with the filter that is available in the module manager.

modules

avatar coolcat-creations
coolcat-creations - comment - 7 Mar 2023

I have the issue on my website where I have a lot of modules that are in use.

avatar brianteeman brianteeman - test_item - 8 Mar 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 Mar 2023

I have tested this item āœ… successfully on de5cdbb

Sorry I wasnt testing it correctly. Issue replicated now and fix confirmed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40040.

avatar coolcat-creations
coolcat-creations - comment - 8 Mar 2023

Thank you @brianteeman !

avatar Quy Quy - test_item - 9 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Mar 2023

I have tested this item āœ… successfully on de5cdbb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40040.

avatar Quy Quy - change - 9 Mar 2023
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 9 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40040.

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar obuisard obuisard - change - 5 May 2023
Labels Added: ? bug
avatar obuisard obuisard - change - 5 May 2023
Labels Added: PR-4.3-dev
avatar obuisard obuisard - close - 5 May 2023
avatar obuisard obuisard - merge - 5 May 2023
avatar obuisard obuisard - change - 5 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-05 20:18:19
Closed_By obuisard
avatar obuisard
obuisard - comment - 5 May 2023

Thank you Elisa @coolcat-creations for the PR :-)

Add a Comment

Login with GitHub to post a comment