User tests: Successful: Unsuccessful:
Pull Request for Issue (no issue). Found while doing code review.
Currently, the array keys passed to MailTemplate::replaceTags()
are directly used within the regular expression. This is prone to errors, if ever some array keys are used that contain special characters (e.g. +
, *
, ...).
Quoting the key should prevent some possible (future) weird behaviour, if an array key contains a regex control character. This should not create any b/c problems, as afaik no keys with special characters are currently defined/used. Also, regular expression control chars could not be used in a sensible way in this place anyways.
it works (the email contains information and no placeholders)
it still works (no visble change to above)
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
This pull request has been automatically rebased to 4.3-dev.
Labels |
Added:
?
bug
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 17:33:36 |
Closed_By | ⇒ | obuisard | |
Labels |
Added:
PR-4.3-dev
|
I have tested this item✅ successfully on 91c2096
Tested successfully in Joomla 4.2.10-dev of 19 March using PHP 8.1.10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40032.