? Success

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
27 Jul 2014

Small improvement of the PR by @andykirk.

Thank you for the work!


Hi

I've created a pluging that makes use of $app->getRouter()->attachBuildRule(...), redirecting things like 'index.php?option=com_users&view=login' to just 'login', and in components\com_users\views\profile\view.html.php on line 66 the redirect is:
$app->redirect(JUri::base() . 'index.php?option=com_users&view=login', '', 302);
Note it doesn't use JRoute::() as I believe it should, which means in those circumstances my plugin doesn't work.
Changing it to:
$app->redirect(JRoute::
('index.php?option=com_users&view=login', false), '', 302);
Fixes it to work as expected.
I guess it would be difficult for people to test this without installing a plugin that does what my plugin is doing, so I'm happy to provide a reduced plugin zip for people to install if necessary.
Please let me know.

Thanks,

Andy

avatar Kubik-Rubik Kubik-Rubik - open - 27 Jul 2014
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar nicksavov nicksavov - change - 21 Aug 2014
Title
Updated and improved PR - Update view.html.php #2665
[#32934] Updated and improved PR - Update view.html.php #2665
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Components
avatar brianteeman brianteeman - change - 16 Jun 2015
The description was changed
avatar brianteeman
brianteeman - comment - 16 Jun 2015

Copied details from joomlacode before they disappear


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4003.

avatar Bakual Bakual - change - 16 Jun 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-06-16 12:44:33
Closed_By Bakual
avatar Bakual Bakual - close - 16 Jun 2015
avatar Bakual
Bakual - comment - 16 Jun 2015

Merged based on review as it's a simple PR and unlikely to be tested.
Gave atribution to @andykirk.

Thanks @Kubik-Rubik for redoing it. :+1:

Add a Comment

Login with GitHub to post a comment