? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar khu5h1
khu5h1
4 Mar 2023

Pull Request for Issue #40001
Guided Tour Project #39902

Summary of Changes

Fixed News Feed Status target

Actual result BEFORE applying this Pull Request

main

Expected result AFTER applying this Pull Request

2

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2023
Category SQL Administration com_admin Postgresql Installation
avatar khu5h1 khu5h1 - open - 4 Mar 2023
avatar khu5h1 khu5h1 - change - 4 Mar 2023
Status New Pending
avatar khu5h1 khu5h1 - change - 4 Mar 2023
The description was changed
avatar khu5h1 khu5h1 - edited - 4 Mar 2023
avatar khu5h1 khu5h1 - change - 8 Mar 2023
Title
[4.3] Fixed News Feed Status target
[4.3] [Guided Tours] Fixed News Feed Status target
avatar khu5h1 khu5h1 - edited - 8 Mar 2023
avatar Quy
Quy - comment - 8 Mar 2023

Please fix update sql files. See samples: 5e4c0dd

avatar khu5h1 khu5h1 - change - 9 Mar 2023
Labels Added: ? PR-4.3-dev
avatar khu5h1 khu5h1 - change - 9 Mar 2023
Title
[4.3] [Guided Tours] Fixed News Feed Status target
[4.3][Guided Tours] Fixed News Feed tour and User tour target
avatar khu5h1 khu5h1 - edited - 9 Mar 2023
avatar obuisard
obuisard - comment - 9 Mar 2023

Khushi @khu5h1 the latest SQL updates are incorrect. They will replace more than what needs to be replaced. You need to be more specific in the WHERE clause :-)

UPDATE `#__guidedtour_steps`
SET `target` = '#jform_published'
WHERE `target` = '#jform_state';
avatar khu5h1
khu5h1 - comment - 9 Mar 2023

@obuisard Sure, Updating the WHERE clause. Thanks!

avatar obuisard obuisard - change - 9 Mar 2023
Labels Removed: ?
avatar obuisard obuisard - test_item - 9 Mar 2023 - Tested successfully
avatar obuisard
obuisard - comment - 9 Mar 2023

I have tested this item successfully on 0dd1365


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

avatar khu5h1
khu5h1 - comment - 10 Mar 2023

Hi @Quy, It would be great if you could test this PR whenever you get time so, that we can merge it before the RC. Thanks!

avatar ChristineWk
ChristineWk - comment - 10 Mar 2023

@obuisard
Unfortunately I hv updated to 4.3.0-beta5-dev (before). Therefore response:
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-02-15.sql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.
avatar obuisard
obuisard - comment - 10 Mar 2023

@obuisard Unfortunately I hv updated to 4.3.0-beta5-dev (before). Therefore response: The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-02-15.sql

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

Hi @ChristineWk. Some times you cannot try patches simultaneously. Once you try a patch you should revert it so that the next patch does not rely on the previous one or create conflict.

avatar ChristineWk
ChristineWk - comment - 10 Mar 2023

Hi @obuisard I tried the patch a few days before. It was unsuccessful. Checked also sql and was not sure about ....
Due to subsequent changes sql - I tried again today, but with an updated 4.3.0-beta5-dev
Had of course reverted before that.

avatar sdwjoomla sdwjoomla - test_item - 11 Mar 2023 - Tested successfully
avatar sdwjoomla
sdwjoomla - comment - 11 Mar 2023

I have tested this item successfully on d8a35b2

Step 7 highlighted the Status field


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

avatar Quy Quy - alter_testresult - 11 Mar 2023 - obuisard: Tested successfully
avatar Quy Quy - change - 11 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

avatar obuisard obuisard - change - 11 Mar 2023
Labels Added: ?
avatar obuisard obuisard - close - 12 Mar 2023
avatar obuisard obuisard - merge - 12 Mar 2023
avatar obuisard obuisard - change - 12 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-12 00:11:23
Closed_By obuisard
avatar obuisard
obuisard - comment - 12 Mar 2023

Thank you Khushi @khu5h1 !

Add a Comment

Login with GitHub to post a comment