Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39997] - [4.3] Replace JPATH_PLATFORM with _JEXEC in dispatcher.php

? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar sandewt
sandewt
4 Mar 2023

Pull Request for Issue # .

Summary of Changes

The constant JPATH_PLATFORM is a history thing and should not be used for new code in Dispatcher.php
This pr replaces this with _JEXEC in some files

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Code: \defined('JPATH_PLATFORM') or die;

Expected result AFTER applying this Pull Request

Code: \defined('_JEXEC') or die;

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomdonation

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2023
Category ⇒ Unit Tests Repository Administration com_admin SQL Postgresql
avatar sandewt sandewt - open - 4 Mar 2023
avatar sandewt sandewt - change - 4 Mar 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2023
Category Unit Tests Repository Administration com_admin SQL Postgresql ⇒ Modules Administration Front End com_contact com_content
avatar sandewt sandewt - change - 4 Mar 2023
Title
…
Patch 2
[4.3] Replace JPATH_PLATFORM' with _JEXEC in dispatcher.php
avatar sandewt sandewt - edited - 4 Mar 2023
avatar sandewt sandewt - change - 4 Mar 2023
Title
…
[4.3] Replace JPATH_PLATFORM' with _JEXEC in dispatcher.php
[4.3] Replace JPATH_PLATFORM with _JEXEC in dispatcher.php
avatar sandewt sandewt - edited - 4 Mar 2023
avatar sandewt sandewt - change - 4 Mar 2023
The description was changed
avatar sandewt sandewt - edited - 4 Mar 2023
avatar sandewt sandewt - change - 4 Mar 2023
The description was changed
avatar sandewt sandewt - edited - 4 Mar 2023
avatar joomdonation joomdonation - test_item - 4 Mar 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 4 Mar 2023

I have tested this item ✅ successfully on fe6ebbe

Looks good to me. Hope no one disagrees with this change.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39997.

avatar sandewt
sandewt - comment - 4 Mar 2023

Looks good to me. Hope no one disagrees with this change.

We will see and wait.

avatar chmst chmst - test_item - 5 Mar 2023 - Tested successfully
avatar chmst
chmst - comment - 5 Mar 2023

I have tested this item ✅ successfully on fe6ebbe

Code Review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39997.

avatar joomdonation joomdonation - change - 5 Mar 2023
Status Pending ⇒ Ready to Commit
avatar joomdonation
joomdonation - comment - 5 Mar 2023

RTC.Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39997.

avatar Quy Quy - change - 7 Mar 2023
Labels Added: ? PR-4.3-dev
avatar obuisard obuisard - change - 8 Mar 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-03-08 00:00:27
Closed_By ⇒ obuisard
avatar obuisard obuisard - close - 8 Mar 2023
avatar obuisard obuisard - merge - 8 Mar 2023
avatar obuisard
obuisard - comment - 8 Mar 2023

Thank you @sandewt for the PR!

Add a Comment

Login with GitHub to post a comment