? ? Pending

User tests: Successful: Unsuccessful:

avatar korenevskiy
korenevskiy
28 Feb 2023

By creating the IMAGES directories in the ADMINISTRATOR directory.
Create the TEST subdirectory in the IMAGES directory.
Go to the settings of the Editor Tinymce plugin and select a subfolder to save images.
We see that the list for selecting subfolders is limited to only one TEST folder.
Thus, the list of the directory from the administrator folder is displayed in the plugin settings. But when saving image files in the materials manager, the files are still saved to the standard image folder. The presence of the IMAGES folder in the Admin folder breaks the configuration setting of the Tinymce editor plugin.

Fix bug fo ISSUE #39946

Addition:

You need to test with having previously created the IMAGES directory in the ADMINISTRATOR directory. Otherwise, there is no point in testing.

Addition @brianteeman

For others looking at this. It is an obscure but valid bug.

The images directory option in TinyMCE should look something like this

Image

In other words it should be displaying the /images directory and all subdirectories.

The bug occurs if you also have a folder /administrator/images

That should have no effect on the field in tiinymce but as shown below it does
Image
image

avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2023
Category Front End Plugins
avatar korenevskiy korenevskiy - open - 28 Feb 2023
avatar korenevskiy korenevskiy - change - 28 Feb 2023
Status New Pending
avatar korenevskiy korenevskiy - change - 28 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 28 Feb 2023
avatar joomdonation joomdonation - test_item - 28 Feb 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 28 Feb 2023

I have tested this item successfully on 8d4093c

Works as expected. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39962.

avatar joomdonation
joomdonation - comment - 28 Feb 2023

For testers, please see this comment #39946 (comment) from @brianteeman . It explains the issue this PR solves clearer than the description of this PR.

avatar viocassel viocassel - test_item - 28 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 28 Feb 2023

I have tested this item successfully on 8d4093c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39962.

avatar korenevskiy korenevskiy - change - 28 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 28 Feb 2023
avatar korenevskiy korenevskiy - change - 28 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 28 Feb 2023
avatar korenevskiy
korenevskiy - comment - 28 Feb 2023

I have tested this item successfully on 8d4093c

Have you tested with the IMAGES directory in the ADMINISTRATOR directory or not?

avatar korenevskiy korenevskiy - change - 28 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 28 Feb 2023
avatar korenevskiy korenevskiy - change - 28 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 28 Feb 2023
avatar joomdonation
joomdonation - comment - 28 Feb 2023

Have you tested with the IMAGES directory in the ADMINISTRATOR directory or not?

Yes. I tested.

avatar joomla-cms-bot joomla-cms-bot - edited - 28 Feb 2023
avatar joomdonation joomdonation - change - 28 Feb 2023
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 28 Feb 2023

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39962.

avatar Quy Quy - change - 28 Feb 2023
Labels Added: ? ?
avatar fancyFranci fancyFranci - change - 28 Feb 2023
Title
Select folder in setting plgEditor Tinymce, will not be select images sub directory for if create directory 'images' in directory 'administrator'
Fix TinyMCE images directory options if '/administrator/images' exists
avatar fancyFranci fancyFranci - edited - 28 Feb 2023
avatar fancyFranci fancyFranci - change - 28 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-28 22:21:43
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 28 Feb 2023
avatar fancyFranci fancyFranci - merge - 28 Feb 2023
avatar fancyFranci
fancyFranci - comment - 28 Feb 2023

Great that you fixed this really obscure bug! Thank you :)

Add a Comment

Login with GitHub to post a comment