[#39955] - [4.3] PHP8.2: Updating voku/portable-utf8
- Fixed in Code Base
- 8 Mar 2023
- Medium
- Build: 4.3-dev
- # 39955
- Diff
- Hackwar:4.3-finder-utf8
User tests: Successful: Unsuccessful:
Pull Request for Issue #39512.
Summary of Changes
Our wamania/php-stemmer requires voku/portable-utf8, which in the 5.4 version is not compatible with PHP 8.2. Version 6.0 actually is and since the code for the stemmer is compatible, we can thus update voku/portable-utf8 now with this. php-stemmer will most likely not update it for the 2.x version we are using. For Joomla 5 this is probably going to be done through our dependency updates.
Testing Instructions
Apply the change (together with composer install) and then run the indexer of smart search and afterwards search something in the frontend. Make sure that the stemmer is selected in the global options of Smart Search by setting "Default Language" to "Default Site Language". All of this in PHP 8.2
Actual result BEFORE applying this Pull Request
You see a notice.
Expected result AFTER applying this Pull Request
You don't see a notice.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Composer Dependency Changed
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39955.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39955.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-08 02:17:15 |
| Closed_By | ⇒ | obuisard |
We have the same problem in 4.2.9
Impossible to install a new 4.2.9 and other issues.
This class is not used during installation of Joomla.
I have tested this item✅ successfully on 44f9ff1
When I run joomla in a webserver with xdebug enabled, like I do with DPDocker, then I get always on the first page load a deprecated warning from voku. With this patch not anymore.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39955.