? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar NicolasDerumigny
NicolasDerumigny
25 Feb 2023

Pull Request for Issue #39936 .

Summary of Changes

ImageListField fetches its list of valid extensions from the com_media valid image extension preference.

Testing Instructions

Add a new ImageListField and set it to a directory containing WEBP images, or any new type defined in the media manager valid image extensions (such as AVIF).

Actual result BEFORE applying this Pull Request

WEBP images are not shown in the list field.

Expected result AFTER applying this Pull Request

WEBP images are shown in the list field.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category Libraries
avatar NicolasDerumigny NicolasDerumigny - open - 25 Feb 2023
avatar NicolasDerumigny NicolasDerumigny - change - 25 Feb 2023
Status New Pending
avatar NicolasDerumigny NicolasDerumigny - change - 25 Feb 2023
The description was changed
avatar NicolasDerumigny NicolasDerumigny - edited - 25 Feb 2023
avatar NicolasDerumigny NicolasDerumigny - change - 25 Feb 2023
The description was changed
avatar NicolasDerumigny NicolasDerumigny - edited - 25 Feb 2023
avatar NicolasDerumigny NicolasDerumigny - change - 25 Feb 2023
Labels Added: ?
avatar Quy
Quy - comment - 25 Feb 2023

Please revert coding style changes.

avatar NicolasDerumigny
NicolasDerumigny - comment - 25 Feb 2023

Which ones? I passed the files to phpcbf in order to comply with the integration tests ; what is the correct formatting here?

avatar Quy
Quy - comment - 26 Feb 2023

https://github.com/joomla/joomla-cms/pull/39942/files

See unrelated changes such as single quote to double quote and removing spaces.

avatar richard67
richard67 - comment - 26 Feb 2023

https://github.com/joomla/joomla-cms/pull/39942/files

See unrelated changes such as single quote to double quote and removing spaces.

@NicolasDerumigny To help you with that I have made review suggestions on GitHub. Just to go the link provided in the above comment. You can add my suggestions to a batch and then commit them, or if that is easier for you just accept it one by one. Thanks in advance.

avatar richard67
richard67 - comment - 26 Feb 2023

Which ones? I passed the files to phpcbf in order to comply with the integration tests ; what is the correct formatting here?

@NicolasDerumigny We use the command here in our integration test:
https://github.com/joomla/joomla-cms/blob/4.2-dev/.drone.yml#L22

./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .

It requires composer install having run before on a git clone in order to get the necessary tools.

avatar NicolasDerumigny
NicolasDerumigny - comment - 27 Feb 2023

Thank you for the clarification. I will use it if I need to PR again. I have accepted all your changes, thanks a lot!

avatar joomdonation
joomdonation - comment - 27 Feb 2023

@NicolasDerumigny Look like we have it fixed in 4.3-dev, please see https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Form/Field/ImagelistField.php#L43 . Maybe we can just backport that change to 4.2-dev ?

(It's simpler. We just list all kind of images, not depend on the settings from Media Manager)

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar obuisard
obuisard - comment - 15 Jul 2023

We have a correction from https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Form/Field/ImagelistField.php#L43 therefore I am closing this PR.
Thank you Nicolas @NicolasDerumigny for the PR and everybody for the help provided.

avatar obuisard obuisard - close - 15 Jul 2023
avatar obuisard obuisard - change - 15 Jul 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-07-15 22:47:46
Closed_By obuisard
Labels Added: ? bug PR-4.3-dev
Removed: ?

Add a Comment

Login with GitHub to post a comment