User tests: Successful: Unsuccessful:
Pull Request for Issue #39936 .
ImageListField
fetches its list of valid extensions from the com_media
valid image extension preference.
Add a new ImageListField
and set it to a directory containing WEBP images, or any new type defined in the media manager valid image extensions (such as AVIF).
WEBP images are not shown in the list field.
WEBP images are shown in the list field.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Which ones? I passed the files to phpcbf
in order to comply with the integration tests ; what is the correct formatting here?
https://github.com/joomla/joomla-cms/pull/39942/files
See unrelated changes such as single quote to double quote and removing spaces.
https://github.com/joomla/joomla-cms/pull/39942/files
See unrelated changes such as single quote to double quote and removing spaces.
@NicolasDerumigny To help you with that I have made review suggestions on GitHub. Just to go the link provided in the above comment. You can add my suggestions to a batch and then commit them, or if that is easier for you just accept it one by one. Thanks in advance.
Which ones? I passed the files to
phpcbf
in order to comply with the integration tests ; what is the correct formatting here?
@NicolasDerumigny We use the command here in our integration test:
https://github.com/joomla/joomla-cms/blob/4.2-dev/.drone.yml#L22
./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .
It requires composer install
having run before on a git clone in order to get the necessary tools.
Thank you for the clarification. I will use it if I need to PR again. I have accepted all your changes, thanks a lot!
@NicolasDerumigny Look like we have it fixed in 4.3-dev, please see https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Form/Field/ImagelistField.php#L43 . Maybe we can just backport that change to 4.2-dev ?
(It's simpler. We just list all kind of images, not depend on the settings from Media Manager)
This pull request has been automatically rebased to 4.3-dev.
We have a correction from https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Form/Field/ImagelistField.php#L43 therefore I am closing this PR.
Thank you Nicolas @NicolasDerumigny for the PR and everybody for the help provided.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-15 22:47:46 |
Closed_By | ⇒ | obuisard | |
Labels |
Added:
?
bug
PR-4.3-dev
Removed: ? |
Please revert coding style changes.