Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39940] - [4.3] fix namespace captcha unit tests

? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
25 Feb 2023

Summary of Changes

  • Fix namespace for tests/Unit/Plugin/Captcha/InvisibleRecaptcha/Extension/InvisibleRecaptchaPluginTest.php and tests/Unit/Plugin/Captcha/Recaptcha/Extension/RecaptchaPluginTest.php
  • Correct indent for php doc blocks

Testing Instructions

Run composer install
Run unit tests

Actual result BEFORE applying this Pull Request

image

Class Joomla\Tests\Unit\Plugin\Task\Checkfiles\Extension\InvisibleRecaptchaPluginTest located in ./tests/Unit/Plugin/Captcha/InvisibleRecaptcha/Extension/InvisibleRecaptchaPluginTest.php does not comply with psr-4 autoloading standard. Skipping.
Class Joomla\Tests\Unit\Plugin\Task\Checkfiles\Extension\RecaptchaPluginTest located in ./tests/Unit/Plugin/Captcha/Recaptcha/Extension/RecaptchaPluginTest.php does not comply with psr-4 autoloading standard. Skipping.

Expected result AFTER applying this Pull Request

No warning when generating optimized autoload files during composer install
Unit tests are still successful

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category ⇒ Unit Tests
avatar heelc29 heelc29 - open - 25 Feb 2023
avatar heelc29 heelc29 - change - 25 Feb 2023
Status New ⇒ Pending
avatar heelc29 heelc29 - change - 25 Feb 2023
The description was changed
avatar heelc29 heelc29 - edited - 25 Feb 2023
avatar laoneo laoneo - change - 25 Feb 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-25 14:52:39
Closed_By ⇒ laoneo
Labels Added: ? PR-4.3-dev
avatar laoneo laoneo - close - 25 Feb 2023
avatar laoneo laoneo - merge - 25 Feb 2023
avatar laoneo
laoneo - comment - 25 Feb 2023

Thanks!

Add a Comment

Login with GitHub to post a comment