[#3993] - [#30404] Updated PR - CDATA for scripts and styles in XHTML documents #906
- Closed
- 8 Oct 2014
- Medium
- Build: staging
- # 3993
- Diff
- Kubik-Rubik:cdata-xhtml
- Foreign ID 30404
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is reference on #906 with a clean fix of the problem without any additional changes.
JoomlaCode: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30404
@Kubik-Rubik can you plz provide more cleaner instructions how to test it? Thanks ;)
@piotr-cz & @Kubik-Rubik Please provide clear test instructions. Current instructions are not clear and I get a lot of errors applying what is suggested now. Thanks.
nicksavov
- | Labels |
Removed:
?
|
||
| Title |
|
||||||
brianteeman
- | Status | New | ⇒ | Pending |
Retrying my request for test instructions.
@piotr-cz & @Kubik-Rubik Please provide clear test instructions. Current instructions are not clear and I get a lot of errors applying what is suggested now. Thanks.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@piotr-cz I am still do not get it...
1) Set document to XHTML mode:
JFactory::getDocument()->setMimeEncoding('application/xhtml+xml');
Where to set it? Just before <head> ?
2) Add inline scripts and styles and JText::script('TPL_BEEZ3_ALTOPEN');
Can you please clarify? These should be added using JDocument or simply inline? I should use CDATA? Can you provide some examples here of inline scripts and styles?
Thank you!
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@test ok
How I tested it. I added this code into the top of Protostar index.php:
$document = JFactory::getDocument();
$document->setMimeEncoding('application/xhtml+xml');
// Add styles
$style = 'body {'
. 'background: #00ff00;'
. 'color: rgb(0,0,255);'
. '}';
$document->addStyleDeclaration($style);Then checked the source of the page - patch added for scripts: //<![CDATA and //]]> and for styles: /*<![CDATA*/ and /*//]>*/
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@test: After applying the patch, the scripts and styles are correctly wrapped in CDATA tags.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3993.
| Status | Pending | ⇒ | Ready to Commit |
phproberto
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-08 09:00:57 |
Thanks