Feature ? Documentation Required PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Feb 2023

Pull Request for Issue #39911 .

Summary of Changes

Updates the menu item to include several missingh settings

Testing Instructions

Steps to reproduce the issue
On a clean site

create the following category structure and add at least one article into each category
Category1
-- Subcategory 1-1
Category 2
-- Subcategory 2-1

create a menu item of type _ List All Categories in an Article Category Tree_

configure the blog layouts tab as normal - note there is no option for number of columns or column direction so it can only use the component settings or those of another menu item for the same category

there is no option to select either the blog or list layouts when you have clicked on a category it will only use the component settings

Apply the PR

You now have all the same options you have for a category blog and category list menu item
The first field in the categories tab lets you chose the layout (blog, list) for each category

B/C

No problems

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2023
Category Front End com_content
avatar brianteeman brianteeman - open - 24 Feb 2023
avatar brianteeman brianteeman - change - 24 Feb 2023
Status New Pending
avatar toivo toivo - test_item - 13 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 13 Mar 2023

I have tested this item successfully on 3eb4621

Tested successfully in Joomla 4.3.0-debta5-dev of 13 March in PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39929.

avatar viocassel viocassel - test_item - 13 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 13 Mar 2023

I have tested this item successfully on 3eb4621


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39929.

avatar Quy Quy - change - 13 Mar 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 13 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39929.

avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar brianteeman
brianteeman - comment - 8 May 2023

This is a bug fix not a new feature

avatar HLeithner
HLeithner - comment - 15 Jun 2023

@brianteeman sorry I didn't see you comment, @obuisard , @sdwjoomla , @laoneo , @MacJoom , @Hackwar can you have a look to reclassify this or merge it in to 5.0, I'm fine with both of it.

avatar obuisard
obuisard - comment - 15 Jun 2023

It's really a matter of deciding if this PR improves or fixes an issue.

On one hand, it does fix the missing layout selection (it seems like it was missing in Joomla 3 as well - unless I am mistaken - ).
On the other hand, this PR adds missing fields (compared to the 'blog' layout) but not all of the missing fields: we are still missing 'featured articles', 'pagination' and 'pagination results'. And the layout between the two views is also different, so it could be improved as well.

image

So, my suggestion: add the missing fields, fix the layout and have this nice PR ready for 5.0. It is a great improvement.

avatar brianteeman brianteeman - change - 15 Jun 2023
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2023-06-15 14:31:27
Closed_By brianteeman
Labels Added: Feature ? Documentation Required PR-5.0-dev
Removed: PR-4.3-dev
avatar brianteeman brianteeman - close - 15 Jun 2023

Add a Comment

Login with GitHub to post a comment