[#39907] - [4.2] Contact form banned emails and content
- Fixed in Code Base
- 22 Feb 2023
- Medium
- Build: 4.2-dev
- # 39907
- Diff
- brianteeman:banned_email
User tests: Successful: Unsuccessful:
Adds a trim so that if the entries are in the form example.com; example2.com then example2.com will still be blocked
Improved the description It is not a list of email addresses but of email addresses or parts of it (e.g. domains).
Pull Request for Issue #39900 .
Actual result BEFORE applying this Pull Request
the second domain is not banned because of the leading space
Expected result AFTER applying this Pull Request
both domains are banned
Updated
the same change has been made to banned words and banned subjects
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_contact |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
?
|
||
Do the following files also need to be changed?
joomla-cms/components/com_contact/src/Rule/ContactEmailRule.php
Lines 52 to 58 in 56c6ad3
you can change them if you want in their own pr. this pr is about the email address
this pr is about the email address
You changed the file of the banned words
@sandewt is right, @brianteeman can you please edit ContactEmailRule.php
and ContactEmailSubjectRule.php also ;)
oh - shoot - changed the wrong file ;)
I have tested this item
Tested:
- Banned Email Address
- Banned Subject
- Banned Text
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39907.
@brianteeman I think it would be useful to expand the test description, see my previous comment above
[EDIT including the title text of this pr]
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39907.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39907.
| Title |
|
||||||
| Labels |
Added:
?
|
||
Thank you.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-22 15:04:36 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Removed:
?
|
||
thanks
I have tested this item✅ successfully on 8737f9a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39907.