Joomla! Issue Tracker | Joomla! CMS #39900

No Code Attached Yet bug

Closed
21 Feb 2023
Medium
Build: 4.2-dev
# 39900

brianteeman
20 Feb 2023

My blog is under a deluge of span from russia :(

In an attempt to block it I have tried to use the banned email function of the contact form.

I have tried various formats for the emails to be blocked but none of them appear to do anything and any contact form submission that I make using a banned domain or even specific address is still processed.

Is this a case of me configuring it wrongly or does this simply not work in Joomla 4

I am not asking for advice about stopping spam. Just about this one specific feature of Joomla

brianteeman - open - 20 Feb 2023

joomla-cms-bot - change - 20 Feb 2023

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 20 Feb 2023

brianteeman - change - 20 Feb 2023

The description was changed

brianteeman - edited - 20 Feb 2023

Fedik - comment - 20 Feb 2023

Should be: mail.ru;list.ru; or just .ru ?

joomla-cms/components/com_contact/src/Rule/ContactEmailRule.php

Lines 50 to 58 in f520c98

    
           $banned = $params->get('banned_email'); 
        
           if ($banned) { 
        
               foreach (explode(';', $banned) as $item) { 
        
                   if ($item != '' && StringHelper::stristr($value, $item) !== false) { 
        
                       return false; 
        
                   } 
        
               } 
        
           }

Fedik - comment - 20 Feb 2023

btw, the ReCaptcha does not protect from spam anymore ~~, same for invisibleReCaptcha~~, from my expiriance.
ReCaptcha v3 works better, but it is not in the core, and probably never be.

brianteeman - comment - 20 Feb 2023

yes the recaptcha is doing nothing and will be removed.

I see now that when it says "Separate multiple email addresses with a semicolon." it is very strict.

I had this mail.ru; list.ru
this failed for list.ru because it was checking for spacelist.ru

brianteeman - comment - 20 Feb 2023

perhaps we should add a trim to the explode??

Fedik - comment - 20 Feb 2023

Yes, because you have a space, it failed.

perhaps we should add a trim to the explode

yea, that sounds as a good idea

richard67 - comment - 20 Feb 2023

The description text is also not correct. It is not a list of email addresses but of email addresses or parts of it (e.g. domains). So maybe it should be "Separate multiple email addresses or parts of emails addresses with a semicolon" or something like that.

Fedik - change - 21 Feb 2023

Labels

Added: bug

Fedik - labeled - 21 Feb 2023

Fedik - comment - 21 Feb 2023

I mark it as bug, need to fix:

add trim
improve description, with info that it allow to use "substring", and maybe with some examples

brianteeman - change - 21 Feb 2023

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2023-02-21 18:05:48
Closed_By		⇒	brianteeman

brianteeman - close - 21 Feb 2023

brianteeman - comment - 21 Feb 2023

Closed see #39907

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#39900] - Contact Form Spam

Add a Comment

	$banned = $params->get('banned_email');

	if ($banned) {
	foreach (explode(';', $banned) as $item) {
	if ($item != '' && StringHelper::stristr($value, $item) !== false) {
	return false;
	}
	}
	}