[#39878] - [5.2] Error handling while create folder in media manager new pr
- Fixed in Code Base
- 18 Jan 2025
- Medium
- Build: 4.3-dev
- # 39878
- Diff
- Kaushik1216:mediafoldername
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #39263
Alternate pr of pr #39793
Summary of Changes
Handling error while create folder by checking enter name by user
Testing Instructions
create folder and try create a folder by input invalid name
Actual result BEFORE applying this Pull Request
php error and create folder modal is open
Expected result AFTER applying this Pull Request
afoldername.mp4
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Language & Strings |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-4.3-dev
|
||
We should not have duplicate folder name validation on the server and client side. So all the client should do is to handle the error properly which comes from the server.
@laoneo but at current stage backend show msg error occured for all validation failure
cases that can handle by this pr
- If user already have a folder name let's say ds if user try to make folder name d@s you get folder created success msg but actually you folder not created because php side validation remove @ in folder name and now folder name ds already exist so no folder created thus resticting user to enter only alphanumaric ,undersocore ,hyphen and period which accepted by php side.
- when user give same file name which already exist only error occured but with this pr user get notification like folder already exist .
- relative path error
thus user not have to put it's effort to find error
Then you need to fix the server side to return proper errors.
Then you need to fix the server side to return proper errors.
yes that can also done but this will increase number of clicks by user .Best way that I got it to show error in modal by @dgrammatiko and from issue #39263 .
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
bug
PR-4.4-dev
PR-5.2-dev
Removed: PR-4.3-dev |
||
I have tested this item ✅ successfully on b1e5105
Test by using Prebuilt update package: Tried to create an existing folder; create a folder having more as one dot.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39878.
I have tested this item ✅ successfully on b1e5105
Nice improvement! Works fine. Thanks also for the clear video demo which made it easy to test!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39878.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39878.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-18 12:28:06 |
| Closed_By | ⇒ | Hackwar |
Thank you!
@dgrammatiko please hint me how this error handling posisble for online storage solution