Language Change NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Kaushik1216
Kaushik1216
17 Feb 2023

Pull Request for Issue #39263
Alternate pr of pr #39793

Summary of Changes

Handling error while create folder by checking enter name by user

Testing Instructions

create folder and try create a folder by input invalid name

Actual result BEFORE applying this Pull Request

php error and create folder modal is open

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2023
Category Administration com_media NPM Change Language & Strings
avatar Kaushik1216 Kaushik1216 - open - 17 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 17 Feb 2023
Status New Pending
avatar Kaushik1216 Kaushik1216 - change - 17 Feb 2023
The description was changed
avatar Kaushik1216 Kaushik1216 - edited - 17 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 17 Feb 2023
Labels Added: Language Change NPM Resource Changed PR-4.3-dev
avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

@dgrammatiko please hint me how this error handling posisble for online storage solution

avatar dgrammatiko
dgrammatiko - comment - 17 Feb 2023

You need to ask @laoneo for this, I'm not well educated on this

avatar laoneo
laoneo - comment - 17 Feb 2023

We should not have duplicate folder name validation on the server and client side. So all the client should do is to handle the error properly which comes from the server.

avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

@laoneo but at current stage backend show msg error occured for all validation failure

cases that can handle by this pr

  1. If user already have a folder name let's say ds if user try to make folder name d@s you get folder created success msg but actually you folder not created because php side validation remove @ in folder name and now folder name ds already exist so no folder created thus resticting user to enter only alphanumaric ,undersocore ,hyphen and period which accepted by php side.
  2. when user give same file name which already exist only error occured but with this pr user get notification like folder already exist .
  3. relative path error
    thus user not have to put it's effort to find error
avatar laoneo
laoneo - comment - 17 Feb 2023

Then you need to fix the server side to return proper errors.

avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

Then you need to fix the server side to return proper errors.

yes that can also done but this will increase number of clicks by user .Best way that I got it to show error in modal by @dgrammatiko and from issue #39263 .

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[4.3] Error handling while create folder in media manager new pr
[4.4] Error handling while create folder in media manager new pr
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 15 Nov 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 15 Nov 2024
Title
[4.4] Error handling while create folder in media manager new pr
[5.2] Error handling while create folder in media manager new pr
avatar HLeithner HLeithner - edited - 15 Nov 2024

Add a Comment

Login with GitHub to post a comment