? Composer Dependency Changed NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
17 Feb 2023

Summary of Changes

Updates the dependencies for the CMS. This composer.json and package.json files are reflecting now the installed versions of the dependencies, like we can easily see what has changed.

To update the PHP dependencies I did run the following commands:
composer bump
composer update

To update the asset (Javascript, CSS) dependencies I did run the following commands
npm update --save
npm run update

Testing Instructions

Browse around in the back end.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2023
Category External Library Composer Change NPM Change
avatar laoneo laoneo - open - 17 Feb 2023
avatar laoneo laoneo - change - 17 Feb 2023
Status New Pending
avatar laoneo laoneo - change - 17 Feb 2023
Labels Added: Composer Dependency Changed NPM Resource Changed PR-4.3-dev
avatar laoneo laoneo - change - 17 Feb 2023
The description was changed
avatar laoneo laoneo - edited - 17 Feb 2023
avatar laoneo laoneo - change - 20 Feb 2023
The description was changed
avatar laoneo laoneo - edited - 20 Feb 2023
avatar dgrammatiko
dgrammatiko - comment - 21 Feb 2023

@laoneo couple of things here:

  • you should remove the optionalDependencies from the package.json, my bad introducing it
  • You should run npm run update and commit the xmls of tinyMCE and codemirror and also the error pages
avatar laoneo laoneo - change - 21 Feb 2023
The description was changed
avatar laoneo laoneo - edited - 21 Feb 2023
avatar laoneo
laoneo - comment - 21 Feb 2023

npm run update has no effect, no files are changed

avatar dgrammatiko
dgrammatiko - comment - 21 Feb 2023

npm run update has no effect, no files are changed

then maybe npm i? The XMLs and the error pages need to be updated

avatar laoneo
laoneo - comment - 21 Feb 2023

Had a look on the XML files and they do have the correct version already. What for error pages do you mean?

avatar dgrammatiko
dgrammatiko - comment - 21 Feb 2023

What for error pages do you mean?

These: templates/system/build_incomplete.html, templates/system/fatal-error.html, templates/system/incompatible.html

avatar brianteeman
brianteeman - comment - 26 Feb 2023

Not going to pretend to understand npm versioning but I would expect at a minimum that after applying this pr and then running npm i to have the latest version that follows the versioning defined in package.json but the package-lock.json is not providing those versions

npm outdated

PS C:\htdocs\j42> npm outdated

Package                        Current   Wanted  Latest
@babel/core                    7.20.12   7.21.0  7.21.0
@dgrammatiko/compress            1.0.4    1.0.4   2.0.0
@fortawesome/fontawesome-free   5.15.4   5.15.4   6.3.0
@rollup/plugin-babel             5.3.1    5.3.1   6.0.3
@rollup/plugin-commonjs         21.1.0   21.1.0  24.0.1
@rollup/plugin-node-resolve     13.3.0   13.3.0  15.0.1
@rollup/plugin-replace           3.1.0    3.1.0   5.0.2
accessibility                   3.0.17   3.0.17   4.5.6
choices.js                       9.1.0    9.1.0  10.2.0
codemirror                     5.65.11  5.65.12   6.0.1
commander                        8.3.0    8.3.0  10.0.0
cypress                        10.11.0  10.11.0  12.7.0
eslint-plugin-vue                8.7.1    8.7.1   9.9.0
fs-extra                        10.1.0   10.1.0  11.1.0
ini                              2.0.0    2.0.0   3.0.1
jasmine-core                    3.99.1   3.99.1   4.5.0
jquery-migrate                   3.4.0    3.4.1   3.4.1
mediaelement                     5.1.1    5.1.1   6.0.1
rimraf                           3.0.2    3.0.2   4.1.2
rollup                          2.79.1   2.79.1  3.17.3
rtlcss                           3.5.0    3.5.0   4.0.0
stylelint                      14.16.1  14.16.1  15.2.0
stylelint-config-standard       24.0.0   24.0.0  30.0.1
stylelint-order                  5.0.0    5.0.0   6.0.2
terser                          5.16.4   5.16.5  5.16.5
tinymce                         5.10.7   5.10.7   6.3.2
vue                             3.2.45   3.2.45  3.2.47
vue-focus-lock                   2.0.2    2.0.5   2.0.5
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2023
Category External Library Composer Change NPM Change External Library Composer Change NPM Change Front End Plugins
avatar laoneo
laoneo - comment - 5 Mar 2023

@brianteeman most of these are major updates which should be done in joomla 5 branch.

avatar brianteeman
brianteeman - comment - 5 Mar 2023

Updated the list to only show minor updates


Package                        Current   Wanted  Latest
@babel/core                    7.20.12   7.21.0  7.21.0
codemirror                     5.65.11  5.65.12   6.0.1
jquery-migrate                   3.4.0    3.4.1   3.4.1
terser                          5.16.4   5.16.5  5.16.5
vue-focus-lock                   2.0.2    2.0.5   2.0.5
avatar laoneo
laoneo - comment - 5 Mar 2023

Can you check with the latest commits? Looks like they are updated since I did it last time.

avatar brianteeman brianteeman - test_item - 5 Mar 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Mar 2023

I have tested this item successfully on b5ef531


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39875.

avatar dgrammatiko dgrammatiko - test_item - 5 Mar 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 5 Mar 2023

I have tested this item successfully on b5ef531


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39875.

avatar richard67 richard67 - change - 5 Mar 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 5 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39875.

avatar obuisard obuisard - close - 5 Mar 2023
avatar obuisard obuisard - merge - 5 Mar 2023
avatar obuisard obuisard - change - 5 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-05 14:49:06
Closed_By obuisard
Labels Added: ?
avatar obuisard
obuisard - comment - 5 Mar 2023

Thank you Allon @laoneo

avatar laoneo
laoneo - comment - 5 Mar 2023

Coo, thank you @obuisard !!

Add a Comment

Login with GitHub to post a comment