[#39870] - [4.2] Prevent fatal error when Itemid from query is invalid
- Fixed in Code Base
- 16 Feb 2023
- Medium
- Build: 4.2-dev
- # 39870
- Diff
- joomdonation:site_router_fatal_error
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR adds a check to make sure Itemid from request points to a valid menu item before merging it's query data with the query from previous process to prevent fatal error.
Testing Instructions
- Type this link directly in the browser http://localhost/joomla/index.php?option=com_content&Itemid=1000 (Note Itemid=1000, there is no menu item with ID = 1000 in the setup, you can replace it with any invalid menu item id)
Actual result BEFORE applying this Pull Request
You get fatal error:
0 array_merge(): Argument #1 must be of type array, null given
Expected result AFTER applying this Pull Request
No fatal error, page displayed OK
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
@Hackwar Is it OK to add this check ? In theory, getItem method from calling code could return null, so I think it makes sense to add the check (we have other similar check in the same class)
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
but strange page rendered
The same thing happens if $query['option'] is not set. See line 395
if (!isset($query['option'])) {
return;
}
In this case I get the following. See the picture.
I don't see a 404 error message or a fatal error.
unset($query['option']);
if (!isset($query['option'])) {
return;
}
ah yes @joomdonation it's correct
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39870.
it is not related to the change in this PR
Indeed.
Also sorry, that I wasn't completely clear @joomdonation
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39870.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-16 12:34:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
ok no more fatal error with pr applyed
but strange page rendered