[#39866] - [4.3] Allow ico files uploads
- Closed
- 15 Feb 2023
- Medium
- Build: 4.3-dev
- # 39866
- Diff
- dgrammatiko:4.3-dev-ico-files
User tests: Successful: Unsuccessful:
Pull Request for Issue #39861 (partially, it allows upload but not delete or any other process) .
Summary of Changes
- ico files are NOT images both for the HTML and the PHP tools
- allow them as exception
Testing Instructions
Try to upload an ico file in the template file manager
Actual result BEFORE applying this Pull Request
Upload successful
Expected result AFTER applying this Pull Request
Not allowed
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@brianteeman I'm not really interested to push this any further, just opened the PR as a base for the solution. You're more than welcome to add the missing pieces...
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-15 19:37:15 |
| Closed_By | ⇒ | dgrammatiko |
@dgrammatiko why have you closed this without merging?
maybe its time to add support for ico files to Joomla?
I need to consult the security team if they are ok with this. Also since there's a security release tomorrow this needs to wait (I guess everybody is quite busy right now). Lastly there are bits and pieces missing so this is not quite ready at this point
Still getting the following: