? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
13 Feb 2023

Pull Request for Issue #39854.

Summary of Changes

Add is_string() check inside htmlspecialchars.

Testing Instructions

See #39854 (comment)

Actual result BEFORE applying this Pull Request

PHP8 error htmlspecialchars(): Argument #1 ($string) must be of type string, array given Line 99.

Expected result AFTER applying this Pull Request

No error.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2023
Category Layout
avatar ReLater ReLater - open - 13 Feb 2023
avatar ReLater ReLater - change - 13 Feb 2023
Status New Pending
avatar ReLater ReLater - change - 13 Feb 2023
Title
[4] PHP8. Argument #1 ($string) must be of type string. Layout text.
[4] PHP8. Argument #1 ($string) must be of type string. JLayout form.field.text.
avatar ReLater ReLater - edited - 13 Feb 2023
avatar ReLater ReLater - change - 13 Feb 2023
The description was changed
avatar ReLater ReLater - edited - 13 Feb 2023
avatar Fedik
Fedik - comment - 13 Feb 2023

I do not like it,
it should explode if it has wrong value, otherwise it will be hard to debug when there soething wrong.

avatar ReLater
ReLater - comment - 13 Feb 2023

Cannot replicate the issue #39854. Sorry for noise.

avatar ReLater ReLater - close - 13 Feb 2023
avatar ReLater ReLater - change - 13 Feb 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-02-13 13:14:07
Closed_By ReLater
Labels Added: ?

Add a Comment

Login with GitHub to post a comment