User tests: Successful: Unsuccessful:
Pull Request for Issue #39774.
PR #38305 changed the logic for array values in mail templates. That PR "fixed" the output of plain arrays, dismissing that core actually uses arrays in a different way, by using nested template tags.
One feature where nested tags are used are the user information emails, and thus they are broken since 4.2.7.
This PR restores the old behavior, but only if the new one is not used. As described by @ReLater in 39774, this fixes the mails not working (on my sites, with default templates) - and it also doesn't break the use-case of the changes in 4.2.7.
Note: I find the changes in #38305 confusing as is breaks the current semantics of templates: beforehand, only text in curly braces was treated as "key", and now also text outside of them. imho, {com_fields}{xyz}{/com_fields}
would have been better than the syntax {com_fields}xyz{/com_fields}
as implemented by #38305...
I suppose the decision on how to put forward the mail templating "language" is not on me, but this PR at least unbreaks old functionality and does not introduce b/c problems to 4.2.7.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-22 17:40:22 |
Closed_By | ⇒ | fancyFranci |
Thank you for bringing this back
I have tested this item✅ successfully on e349ab4
Tested successfully in Joomla 4.2.8-dev of 13 February in Wampserver 3.2.9 using PHP 8.1.10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39850.