? ? Pending

User tests: Successful: Unsuccessful:

avatar ManuelHu
ManuelHu
12 Feb 2023

Pull Request for Issue #39774.

Summary of Changes

PR #38305 changed the logic for array values in mail templates. That PR "fixed" the output of plain arrays, dismissing that core actually uses arrays in a different way, by using nested template tags.

One feature where nested tags are used are the user information emails, and thus they are broken since 4.2.7.

This PR restores the old behavior, but only if the new one is not used. As described by @ReLater in 39774, this fixes the mails not working (on my sites, with default templates) - and it also doesn't break the use-case of the changes in 4.2.7.

Additional remarks on #38305

Note: I find the changes in #38305 confusing as is breaks the current semantics of templates: beforehand, only text in curly braces was treated as "key", and now also text outside of them. imho, {com_fields}{xyz}{/com_fields} would have been better than the syntax {com_fields}xyz{/com_fields} as implemented by #38305...

I suppose the decision on how to put forward the mail templating "language" is not on me, but this PR at least unbreaks old functionality and does not introduce b/c problems to 4.2.7.

Testing Instructions

  • Install joomla 4.2.7
  • Make sure action logs for user events are enabled and configure working system email sending
  • In the user settings for a user with a valid email address (you can receive mail on), enable user action information emails for the user component.
  • Log out and log back in
  • Look at the emails you should have received

Actual result BEFORE applying this Pull Request

  • You get information emails about user activity, but they only contain the table header and no specific contents,

Expected result AFTER applying this Pull Request

  • You get information emails that also contain information about the user action (like <=4.2.6)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2023
Category Libraries
avatar ManuelHu ManuelHu - open - 12 Feb 2023
avatar ManuelHu ManuelHu - change - 12 Feb 2023
Status New Pending
avatar ManuelHu ManuelHu - change - 12 Feb 2023
The description was changed
avatar ManuelHu ManuelHu - edited - 12 Feb 2023
avatar toivo toivo - test_item - 13 Feb 2023 - Tested successfully
avatar toivo
toivo - comment - 13 Feb 2023

I have tested this item successfully on e349ab4

Tested successfully in Joomla 4.2.8-dev of 13 February in Wampserver 3.2.9 using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39850.

avatar viocassel viocassel - test_item - 13 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 13 Feb 2023

I have tested this item successfully on e349ab4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39850.

avatar Quy Quy - change - 13 Feb 2023
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 13 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39850.

avatar roland-d roland-d - change - 22 Feb 2023
Labels Added: ?
avatar fancyFranci fancyFranci - close - 22 Feb 2023
avatar fancyFranci fancyFranci - merge - 22 Feb 2023
avatar fancyFranci fancyFranci - change - 22 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-22 17:40:22
Closed_By fancyFranci
avatar fancyFranci
fancyFranci - comment - 22 Feb 2023

Thank you for bringing this back

Add a Comment

Login with GitHub to post a comment