User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Updated git ignore so that image folder ignored
Images inside images folder is track by git
images inside images folder is not track by git anymore
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Repository |
Status | New | ⇒ | Pending |
If we add images in our images folder other than joomla default images it is tracked by git so if we create pr that images will come
considering this I add images folder in gitignore .As I am beginner in joomla ,Please give a reason why images folder should not ignore ,Thanks in advance
When we add the images finder to gitignore, we can’t maintain anymore on GitHub the images provided by the CMS core. When you work on a git clone of the CMS and add new images, you should clean up your branch before working on pull requests, or better use different branches for testing and making pull requests, and the testing branches you reset with git clean command so you never check in accidentally any stuff you have added for testing, like images or whatever.
Closing for the reasons stated above.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-12 11:12:39 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
?
|
In addition any additional images will be added to your pull request ONLY if you commit them to your branch
Why would we want to do that? Please think carefully about what this will mean.