? Pending

User tests: Successful: Unsuccessful:

avatar Kaushik1216
Kaushik1216
12 Feb 2023

Pull Request for Issue # .

Summary of Changes

Updated git ignore so that image folder ignored

Testing Instructions

Actual result BEFORE applying this Pull Request

Images inside images folder is track by git

Expected result AFTER applying this Pull Request

images inside images folder is not track by git anymore

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2023
Category Repository
avatar Kaushik1216 Kaushik1216 - open - 12 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 12 Feb 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 12 Feb 2023

Why would we want to do that? Please think carefully about what this will mean.

avatar Kaushik1216
Kaushik1216 - comment - 12 Feb 2023

If we add images in our images folder other than joomla default images it is tracked by git so if we create pr that images will come
considering this I add images folder in gitignore .As I am beginner in joomla ,Please give a reason why images folder should not ignore ,Thanks in advance

avatar richard67
richard67 - comment - 12 Feb 2023

When we add the images finder to gitignore, we can’t maintain anymore on GitHub the images provided by the CMS core. When you work on a git clone of the CMS and add new images, you should clean up your branch before working on pull requests, or better use different branches for testing and making pull requests, and the testing branches you reset with git clean command so you never check in accidentally any stuff you have added for testing, like images or whatever.

avatar richard67
richard67 - comment - 12 Feb 2023

Closing for the reasons stated above.

avatar richard67 richard67 - close - 12 Feb 2023
avatar richard67 richard67 - change - 12 Feb 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-02-12 11:12:39
Closed_By richard67
Labels Added: ?
avatar brianteeman
brianteeman - comment - 12 Feb 2023

In addition any additional images will be added to your pull request ONLY if you commit them to your branch

Add a Comment

Login with GitHub to post a comment