Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39841] - Correct name of cypress.config in `build/build.php`

PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
11 Feb 2023

cypress.config.js was removed from package in #39478
Then the file was renamed in #39722

avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2023
Category ⇒ Repository
avatar astridx astridx - open - 11 Feb 2023
avatar astridx astridx - change - 11 Feb 2023
Status New ⇒ Pending
avatar wilsonge
wilsonge - comment - 11 Feb 2023

If this is in the beta release then we’ll need to add it to the delete files script too

avatar richard67
richard67 - comment - 12 Feb 2023

If this is in the beta release then we’ll need to add it to the delete files script too

@wilsonge Yes, even before beta we did that. But we do not bother authors of pull requests with that. Instead, I regularly do that before each release since alpha 1 :-)

avatar richard67
richard67 - comment - 12 Feb 2023

@wilsonge P.S.: Or did you mean the cleanup step in build.php so it does not go into packages? silly me, that’s what this PR does.

avatar richard67
richard67 - comment - 12 Feb 2023

It seems the preparation step for the system tests is failing in drone because cypress wants to use the file which with this PR is removed from the build. @Hackwar could you have a look on that? Does it need to change something in drone.xml, too?
Update: False alarm. Branch update has fixed it.

avatar richard67
richard67 - comment - 12 Feb 2023

Will update the branch, maybe this helps with drone.

avatar richard67 richard67 - change - 12 Feb 2023
Labels Added: PR-4.3-dev
avatar laoneo laoneo - change - 13 Feb 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-13 08:02:22
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 13 Feb 2023
avatar laoneo laoneo - merge - 13 Feb 2023
avatar laoneo
laoneo - comment - 13 Feb 2023

Thanks!

Add a Comment

Login with GitHub to post a comment