? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Feb 2023

Pull Request for Issue #36965 .

Summary of Changes

I added fallback from xhtml to html5.
Improved perfomance check, and removed useles things.

Testing Instructions

Please follow #36965

Create a cutom module.
Activate the title of this module
Load this module into an article with {loadposition position-name}

Go to pluging "Content - Load Modules", set style "Wrapped by div".

View the article page, before and after patch.

Repeat the test for {loadmodule mod_name,mod title} placeholder.

Actual result BEFORE applying this Pull Request

Module displaied without title

Expected result AFTER applying this Pull Request

Module displaied with title

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2023
Category Layout Front End Plugins
avatar Fedik Fedik - open - 11 Feb 2023
avatar Fedik Fedik - change - 11 Feb 2023
Status New Pending
0bf3458 11 Feb 2023 avatar Fedik phpcs
avatar Fedik Fedik - change - 11 Feb 2023
Labels Added: ?
avatar sandewt sandewt - test_item - 14 Feb 2023 - Tested successfully
avatar sandewt
sandewt - comment - 14 Feb 2023

I have tested this item successfully on 20af46a

See comment


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39839.

avatar sandewt
sandewt - comment - 14 Feb 2023

Before:
issue-36965-before

After:
issue-36965-after

[EDIT image]

avatar viocassel viocassel - test_item - 15 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 15 Feb 2023

I have tested this item successfully on 20af46a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39839.

avatar sandewt
sandewt - comment - 15 Feb 2023

I ran Test 2 without mod_ as a prefix !!!

In retrospect, this did not seem quite right to me.

To be sure, I therefore did a Test 3 with mod_custom.
See the picture:
issue-36965-after-2

@Fedik Please your opinion? Did you mean it like that?

avatar Fedik
Fedik - comment - 15 Feb 2023

@sandewt both is valid, {loadmodule mod_custom,title} and {loadmodule custom,title} should work the same

avatar sandewt
sandewt - comment - 15 Feb 2023

@Fedik Thanks for the confirmation.

avatar richard67 richard67 - change - 15 Feb 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 15 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39839.

avatar roland-d roland-d - change - 22 Feb 2023
Labels Added: ?
avatar roland-d roland-d - close - 22 Feb 2023
avatar roland-d roland-d - merge - 22 Feb 2023
avatar roland-d roland-d - change - 22 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-22 18:34:45
Closed_By roland-d
avatar roland-d
roland-d - comment - 22 Feb 2023

Thank you

Add a Comment

Login with GitHub to post a comment