NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Kaushik1216
Kaushik1216
7 Feb 2023

Pull Request for Issue # .

Help Needed !

I do not know how add language variable in joomla .So I just used put any other language .I want COM_MEDIA_NO_SEARCH_RESULT="Info No Matching Results " add on language that is used to display when no result found.I try by putting this line in com_media.ini in adminstartor language file but unable to access it in browser.vue ,Please Guide me then I will make chages in this pr for desire output.
Thanks in advanced

Summary of Changes

ADD a messge that will display when no result found on searching in media manager

Testing Instructions

Search in media manager

Actual result BEFORE applying this Pull Request

No message shown if no result match .

Expected result AFTER applying this Pull Request

A message will shown if result not match with search

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2023
Category Administration com_media NPM Change
avatar Kaushik1216 Kaushik1216 - open - 7 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 7 Feb 2023
Status New Pending
avatar Kaushik1216 Kaushik1216 - change - 7 Feb 2023
Labels Added: NPM Resource Changed ?
avatar rajputanuj31
rajputanuj31 - comment - 8 Feb 2023

To add add language variable in joomla you have to add your text in 3 files.
administrator/components/com_media/tmpl/media/default_texts.php
administrator/language/en-GB/com_media.ini
language/en-GB/com_media.ini
Add your text in alpha order.

avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2023
Category Administration com_media NPM Change Administration com_media NPM Change Language & Strings
avatar Kaushik1216 Kaushik1216 - change - 8 Feb 2023
Labels Added: Language Change
avatar Kaushik1216
Kaushik1216 - comment - 8 Feb 2023

Now msg is change to this

search

But unable to understand drone ci error check if anyone understand please tell me

avatar dgrammatiko
dgrammatiko - comment - 8 Feb 2023

@Kaushik1216 please rebase your PR on 4.3-dev as it's a new feature and also in the 4.3-dev branch there are more changes that will collide with anything you're doing here and make it very hard hard to up merge the changes.

avatar Kaushik1216
Kaushik1216 - comment - 8 Feb 2023

@dgrammatiko Sorry I don't know how to rebase my PR to 4.3 because my fork not have 4.3 branch
What I can do then?

avatar dgrammatiko
dgrammatiko - comment - 8 Feb 2023

Next to the title of the PR there's an Edit button. When you click it there's an option to change the base Branch, select 4.3-dev. Then in your local setup just fetch/pull and you're good to go. Probably things need to be changed as the components have already differences...

avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2023
Category Administration com_media NPM Change Language & Strings Administration com_media NPM Change com_menus Language & Strings Libraries Modules Front End
avatar Kaushik1216 Kaushik1216 - change - 8 Feb 2023
Title
No search result found msg in media
[4.3]No search result found msg in media
avatar Kaushik1216 Kaushik1216 - edited - 8 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 8 Feb 2023
Labels Added: PR-4.3-dev
avatar Kaushik1216 Kaushik1216 - change - 9 Feb 2023
Labels Removed: ?
avatar sandewt
sandewt - comment - 9 Feb 2023

The following error message appears when I try to apply the patch:

com_medioa-zoeken

avatar brianteeman
brianteeman - comment - 9 Feb 2023

@sandewt you can't use the patchtester component for this

avatar dgrammatiko
dgrammatiko - comment - 9 Feb 2023

The PR at the current state is wrong as it is undoing most of the changes in the 4.3 branch...
@Kaushik1216 please restore the 4.3-dev browser.vue from here: https://github.com/joomla/joomla-cms/blob/4.3-dev/administrator/components/com_media/resources/scripts/components/browser/browser.vue and then add the changes on top of that.

avatar Kaushik1216
Kaushik1216 - comment - 9 Feb 2023

@dgrammatiko I resolve conflict .Please check why build Check is falling

avatar dgrammatiko
dgrammatiko - comment - 9 Feb 2023

Run npm run lint:js and you will see what's wrong. Also read https://github.com/joomla/joomla-cms/tree/4.2-dev/build

avatar Kaushik1216
Kaushik1216 - comment - 9 Feb 2023

This is what I am getting

errormedia

avatar dgrammatiko
dgrammatiko - comment - 9 Feb 2023

@Kaushik1216 delete your node_modules folder and then run npm install

Also you need to revert the changes on all the unrelated files

And finally you have to restore all the deleted empty lines in the browser.vue

avatar Kaushik1216
Kaushik1216 - comment - 9 Feb 2023

@Kaushik1216 delete your node_modules folder and then run npm install

Also you need to revert the changes on all the unrelated files

And finally you have to restore all the deleted empty lines in the browser.vue

thx by doing npm install all error resolve ? And other than browser.vue I just add spaces in some line which is shown by build ci joomla-cms/administrator/components/com_media/resources/scripts/components/browser/table/table.vue

avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2023
Category Administration com_media NPM Change Language & Strings com_menus Libraries Modules Front End Administration com_media NPM Change Language & Strings Modules Front End
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2023
Category Administration com_media NPM Change Language & Strings Modules Front End Administration com_media NPM Change Language & Strings
avatar Quy
Quy - comment - 15 Feb 2023

Match markup.

<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>

In Media:
39819-media

In Articles:
39819-article

avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

Match markup.

<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>

In Media: 39819-media

In Articles: 39819-article

Thanks for testing ,I made change in pr please check again .

avatar sandewt
sandewt - comment - 16 Feb 2023

Thanks for testing ,I made change in pr please check again .

No possible yet: npm ERR!

avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

Thanks for testing ,I made change in pr please check again .

No possible yet: npm ERR!

@Kaushik1216 delete your node_modules folder and then run npm install

Also you need to revert the changes on all the unrelated files

And finally you have to restore all the deleted empty lines in the browser.vue

Thanks for testing ,I made change in pr please check again .

No possible yet: npm ERR!

try by deleting nodemodules and run npm installl as suggest by @dgrammatiko above

avatar dgrammatiko
dgrammatiko - comment - 16 Feb 2023

@Kaushik1216 no, deleting the node_modules is not the case. Your PR at the end of this page says that:

This branch is out-of-date with the base branch

You have to update the the base branch, google it

avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

branch updated

avatar sandewt
sandewt - comment - 16 Feb 2023

branch updated

Sorry, still npm ERR!

avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

@Quy can you please test again if you also faced same npm error than error comes from my side and vice versa

avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2023
Category Administration com_media NPM Change Language & Strings Administration com_media NPM Change
avatar sandewt
sandewt - comment - 16 Feb 2023

@Kaushik1216

This branch is (still) out-of-date with the base branch

avatar Kaushik1216 Kaushik1216 - change - 16 Feb 2023
Labels Removed: Language Change
avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

@Quy @sandewt I don't know why build is killing in this pr I create another Pr #39872 for this feature

avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

@Quy @sandewt I don't know why build is killing in this pr I create another Pr #39872 for this feature

please test it thanks is advance

avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

closing as another pr created

avatar Kaushik1216 Kaushik1216 - close - 17 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 17 Feb 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-02-17 04:26:40
Closed_By Kaushik1216

Add a Comment

Login with GitHub to post a comment