No Code Attached Yet bug
avatar niosme
niosme
6 Feb 2023

Steps to reproduce the issue

Add Custom class to joomla module from advanced settings in a module at the field class module.
e.g. custom module
or menu module

Expected result

custom class added next to mod-custom for custom module
for menu module next to mod-menu
e.t.c.

Actual result

No class added

System information (as much as possible)

Additional comments

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
4.00

avatar niosme niosme - open - 6 Feb 2023
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Feb 2023
avatar brianteeman
brianteeman - comment - 6 Feb 2023

make sure that the module chrome for that module position is one that uses the class.

avatar niosme
niosme - comment - 6 Feb 2023

Its the same module.
What is a chrome?

Agamemnon Fakas

6 Φεβ 2023, 17:14, ο χρήστης «Brian Teeman @.***>» έγραψε:



make sure that the module chrome for that module position is one that uses the class.


Reply to this email directly, view it on GitHub#39806 (comment), or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXC2UWFTSN6DUISYRME2HIDWWEIM3ANCNFSM6AAAAAAUSZHNJQ.
You are receiving this because you authored the thread.Message ID: @.***>

avatar indotantra
indotantra - comment - 8 Feb 2023

The Joomla module's advanced settings allow for adding a user-defined class.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39806.

avatar Scrabble96
Scrabble96 - comment - 14 Feb 2023

@niosme asks "what is a chrome?"

A chrome is the styling for the module - it relates to style="name-of-style" in the index.php where the code to insert a module position is placed.

If you are using the Cassiopeia template, have a look in the index.php at line 135 where the 'topbar' menu module is. In that line it is style="none". Look further down at the 'top-a' module and you'll see it says "style="card". 'card' is the name of a chrome, which you'll find in /templates/cassiopeia/html/layouts/chromes/ along with another called 'noCard'.

In your module, go to the 'Advanced' tab and scroll to the bottom. There you'll see 'Module Style' where you can select various styles (chromes) including any that you design yourself.

If you're not using Cassiopeia and want to design your own chrome, you'll need to create the /html/layouts/chromes directory path and copy either 'card' or 'noCard' into a new file with a different name to use as a starting point as there is currently no option to do so via a template override.

avatar niosme
niosme - comment - 17 Feb 2023

First of all thanks for explanation. I use cassiopeia child template i made but i use no chrome in those template positions or the module. Its the mod_menu and mod_custom where the problem still exists. In your installation it adds the custom class on those two modules?

Agamemnon Fakas

14 Φεβ 2023, 19:30, ο χρήστης «Scrabble96 @.***>» έγραψε:



@niosmehttps://github.com/niosme asks "what is a chrome?"

A chrome is the styling for the module - it relates to style="name-of-style" in the index.php where the code to insert a module position is placed.

If you are using the Cassiopeia template, have a look in the index.php at line 135 where the 'topbar' menu module is. In that line it is style="none". Look further down at the 'top-a' module and you'll see it says "style="card". 'card' is the name of a chrome, which you'll find in /templates/cassiopeia/html/layouts/chromes/ along with another called 'noCard'.

In your module, go to the 'Advanced' tab and scroll to the bottom. There you'll see 'Module Style' where you can select various styles (chromes) including any that you design yourself.

If you're not using Cassiopeia and want to design your own chrome, you'll need to create the /html/layouts/chromes directory path and copy either 'card' or 'noCard' into a new file with a different name to use as a starting point as there is currently no option to do so via a template override.


Reply to this email directly, view it on GitHub#39806 (comment), or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXC2UWEGSTTXKN4CWN7T5SLWXO6K3ANCNFSM6AAAAAAUSZHNJQ.
You are receiving this because you were mentioned.Message ID: @.***>

avatar Hackwar Hackwar - change - 22 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 22 Feb 2023
avatar niosme
niosme - comment - 23 Feb 2023

As i checked in the menu module and in custom module the params we get are the following
Joomla\Registry\Registry Object ( [data:protected] => stdClass Object ( [menutype] => footer-menu [base] => [startLevel] => 1 [endLevel] => 0 [showAllChildren] => 1 [tag_id] => [class_sfx] => testtt [window_open] => [layout] => _:default [moduleclass_sfx] => testtttaaa [cache] => 1 [cache_time] => 900 [cachemode] => itemid [module_tag] => div [bootstrap_size] => 0 [header_tag] => h3 [header_class] => [style] => 0 ) [initialized:protected] => 1 [separator] => . )

but the param [moduleclass_sfx] is never used inside the module.
also the bootstrap_size is never used and maybe some other parameters.
The same with the custom_module. This is a problem because we cannot attach a custom class to a module to style it or refer to it.

IMPORTANT ALSO:
There is no module title in those to modules. Show Hide Title not works. There's no where in code and cannot put a title label in menu module or in custom module.

avatar brianteeman
brianteeman - comment - 23 Feb 2023

The solution is exactly what you have already beehn told by @Scrabble96. If you dont use a chrome/modulestyle then you will only get the content. You need to use a chrome/modulestyle

@Hackwar there is no bug here and it should be closed.

avatar niosme
niosme - comment - 23 Feb 2023

Yes. Using the html5 layout module looks like fixing the problem. The template cassiopeia in bottom and top positions have noCard or none witch not show the modules title and classes.
Its template configured like that should change module layout html5 ( style="html5" in template position) by default or inside module by the setting it have.
Yes close the topic is not a bug. Im sorry!

avatar alikon
alikon - comment - 23 Feb 2023

closing

avatar alikon alikon - close - 23 Feb 2023
avatar alikon alikon - change - 23 Feb 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-02-23 14:54:23
Closed_By alikon

Add a Comment

Login with GitHub to post a comment