Feeling Lucky
?
PR-4.3-dev
[#39798] - [4.3] Typo
- Fixed in Code Base
- 6 Feb 2023
- Medium
- Build: 4.3-dev
- # 39798
- Diff
- brianteeman:typo1
User tests: Successful: Unsuccessful:
Correct the spelling of DEPLOY_VERSION
needs to be merged before beta release or the script to insert the version will not work
Testing Instructions
code review
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
Quy
- comment
- 5 Feb 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39798.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
Quy
- comment
- 5 Feb 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39798.
laoneo
- comment
- 5 Feb 2023
Should we not hardcode it with the correct value?
brianteeman
- comment
- 5 Feb 2023
No. Its new code so it is correct to be DEPLOY_VERSION isn't it?
laoneo
- comment
- 5 Feb 2023
Yes you are right it's on 4.3
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-06 07:45:21 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
laoneo
- comment
- 6 Feb 2023
Thanks!
I have tested this item✅ successfully on 90b19ef
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39798.