[#39796] - [4.3][bug] Fix the infobar gap
- Fixed in Code Base
- 8 Feb 2023
- Medium
- Build: 4.2-dev
- # 39796
- Diff
- dgrammatiko:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #39792 .
Summary of Changes
Fixes the 4.2 up merge by removing a redundant line
Testing Instructions
- Check that the infobar doesn't have any gap
- Check that an empty folder has correctly entered the upload icon
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Category | Administration com_media NPM Change | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Unit Tests Repository com_admin SQL Postgresql | ⇒ | Administration com_media NPM Change Modules Front End |
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
Removed: ? |
||
| Category | Administration com_media NPM Change Modules Front End | ⇒ | Administration com_media NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39796.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39796.
I know we are in a freeze but this really should be merged before the beta release
I know we are in a freeze but this really should be merged before the beta release
I will agree. @obuisard it's up to you
This issue is unfortunate but is not critical to the functioning of the beta 1 version. We just entered the beta phase. This is the time to find bug and fix them. This fix will be merged in beta 2, as we are in beta 1 freeze right now, which is a time we take to make sure the packages we will provide to the public in a couple of days are properly built, installable and won't break people's test websites. Thank you very much Dimitris @dgrammatiko for this quick fix.
@obuisard ok but it would be better if people could also experience and play around with a fully functional Media Manager(?). Also this bug makes me look bad as it is my code conflicting with changes made in the 4.2 but for most people it would be Dimitris broke the media manager...
@obuisard ok but it would be better if people could also experience and play around with a fully functional Media Manager(?). Also this bug makes me look bad as it is my code conflicting with changes made in the 4.2 but for most people it would be
Dimitris broke the media manager...
The media manager is fully functional, isn't it? Other than the extra space and the possible overlaps, I mean.
You have been greatly improving the media manager, anybody blaming you would not be in any position to do so. Those who do nothing can't break anything.
I think, people can play around with the media manager. This button is very useful but surely not used too often. I must say that I never used it, and it does not break the function. The ordering button is a better toy :)
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-08 22:19:19 |
| Closed_By | ⇒ | obuisard |
Thank you Dimitris @dgrammatiko for your fix!
I have tested this item✅ successfully on 12b5c0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39796.