? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
3 Feb 2023

Summary of Changes

Minor rework of input styling across both backend and frontend templates. The aim of this is to use more of the native bootstrap variables so that our rendering is more consistent. This also makes it easier for people to reuse our SCSS files that we distribute by using more of the bootstrap mixins (e.g. using the box-shadow and border-radius mixins).

Testing Instructions

Go through native select, input, choices (both multiselect and single select - e.g. category and tags form fields in frontend editing) form fields in both cassieopia and atum. The changes should not be noticeable before and after.

For bonus points:

  • Only find an extension still using chosen and test that too.
  • Set enable-rounded variable to false in either casseopia or atum. Before patch only native BS fields were square and the rest were round. After they all act the same way.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 3 Feb 2023
avatar wilsonge wilsonge - change - 3 Feb 2023
Status New Pending
avatar wilsonge wilsonge - change - 3 Feb 2023
Title
Normalize styling of inputs
[4.3] Normalize styling of inputs
avatar wilsonge wilsonge - edited - 3 Feb 2023
avatar wilsonge wilsonge - change - 3 Feb 2023
The description was changed
avatar wilsonge wilsonge - edited - 3 Feb 2023
avatar dgrammatiko dgrammatiko - test_item - 3 Feb 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2023

I have tested this item successfully on e74918b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39781.

avatar viocassel viocassel - test_item - 3 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 3 Feb 2023

I have tested this item successfully on e74918b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39781.

avatar Quy Quy - change - 3 Feb 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 3 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39781.

avatar Quy Quy - change - 3 Feb 2023
Labels Added: ? NPM Resource Changed
avatar obuisard obuisard - change - 4 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-04 04:54:50
Closed_By obuisard
avatar obuisard obuisard - close - 4 Feb 2023
avatar obuisard obuisard - merge - 4 Feb 2023
avatar obuisard
obuisard - comment - 4 Feb 2023

Thank you, George @wilsonge for this PR!

Add a Comment

Login with GitHub to post a comment