Feeling Lucky
?
Release Blocker
?
[#39764] - [4.2.7] Fix PHP 7.2 compatibility of new actionlogs dispatcher - no comma after last method call argument
- Fixed in Code Base
- 31 Jan 2023
- Medium
- Build: 4.2-dev
- # 39764
- Diff
- richard67:4.2-dev-fix-actionlogs-dispatcher-for-php-7-2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
With the 4.2.7 security fixes a method call was introduced which has a comma after the last argument. This is not supported with PHP 7.2.
This PR here fixes it.
Testing Instructions
Code review, or verify that action logs are still working on PHP 7.2.
Actual result BEFORE applying this Pull Request
PHP error on PHP 7.2.
Expected result AFTER applying this Pull Request
No PHP error on PHP 7.2.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration |
| Status | New | ⇒ | Pending |
dgrammatiko
- comment
- 31 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39764.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Release Blocker
?
|
||
richard67
- comment
- 31 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39764.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-31 19:03:27 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
alikon
- comment
- 31 Jan 2023
one of the most fastest pr
fancyFranci
- comment
- 31 Jan 2023
:D Indeed. Thank you Richard!
I have tested this item✅ successfully on ccc812f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39764.