[#39751] - [5.0] Smart Search: Fixing taxonomy filter handling
- Fixed in Code Base
- 30 May 2023
- Medium
- Build: 4.2-dev
- # 39751
- Diff
- Hackwar:4.2-finder-filters
User tests: Successful: Unsuccessful:
Pull Request for Issue #39718 .
Summary of Changes
When I refactored the taxonomies to be a nested set, I overlooked this part. This means that nested taxonomies in filters don't work.
Testing Instructions
- Create an article in a category which is at least on the second level.
- Create a filter which only searches in that articles parent category.
- Go to the frontend and search for a word in that article. You will get the article as result.
- Add &f=[filter-id] to the URL to only show results from our category.
- Notice that you get no result at all!
- Apply changes.
- Only the article appears again.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@crystalenka can you check if this fixes your issue?
Votes
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
Unfortunately this does not fix the problem in a multilingual environment. :(
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39751.
Looks good but it doesnt work. Give it a try. Search for "ricotta" in for example Pasta & Risotto recipes.
See as example: https://www.dolcevia.com/nl/italiaanse-recepten/pasta-gnocchi-risotto/4501-cannelloni-van-grano-arso-met-ricotta-en-spek-in-honingsaus
Search is on the right / sidebar.
@EJBJane without having more knowledge about your setup, it is difficult to judge your report. Yes, you don't get a result when searching for ricotta, but I also don't know what you have in the filter that is activated on your search. If you want me to debug that, please contact me on the Joomla Mattermost.
@EJBJane without having more knowledge about your setup, it is difficult to judge your report. Yes, you don't get a result when searching for ricotta, but I also don't know what you have in the filter that is activated on your search. If you want me to debug that, please contact me on the Joomla Mattermost.
I have to take this back, it was my fault, there was accidently an author selected for the results. This is why the search results didnt work, because there was no recipe with that author. I'm sorry!
It thus does work for me.
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Labels |
Added:
PR-4.3-dev
|
||
I'm sorry, I accidently changed the base branch to 4.3-dev and then updated the branch with the latest changes. I actually didn't want to do that. The forced push only restores the previous state. So, we only need one more test to get this fix on the road.
| Title |
|
||||||
Since there wont be any more patch releases in 4.2, I'm moving this over to 4.3-dev.
I have tested this item
This fixed it in multilingual along with the second PR you linked. Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39751.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39751.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:34 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
?
bug
Removed: ? |
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:34 | ⇒ | |
| Closed_By | Hackwar | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
Removed: PR-4.3-dev |
||
Yes
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-30 11:33:59 |
| Closed_By | ⇒ | HLeithner |
thanks
I guess that answers that it definitely won't go in earlier, but could either of you please help me understand why? This is a bug and filters straight up don't work without the fix.
No that's not the answer and completely independent, this fix can still be back-ported @sdwjoomla and @obuisard can do this or ask for a pr.
The PR got a RTC label over 2 months ago and after a month of no activity from the maintainers I decided to just switch all my PRs to 5.0 in the hopes that they will at least be merged then, especially since I got messages that my PRs don't have a high chance of being merged into 4.x. So instead of wasting my time by rebasing it to 4.4 and then to 5.0, I skipped one step. It's already enough that such a fix had to be rebased from 4.2 to 4.3...
Hello. I would like to ask if this will come to 4.3 at all?
Thank you!! Will test shortly.