? Language Change PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Jan 2023

This PR improves the message for the media manager when the file is too large by describing and adding a link to the media manager options

To test

Go to the media manager component options and change the maximum size from the default of 10 to 1Mb Try to upload an image larger than 1MB

Before

image

After

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2023
Category Administration com_media Language & Strings
avatar brianteeman brianteeman - open - 29 Jan 2023
avatar brianteeman brianteeman - change - 29 Jan 2023
Status New Pending
avatar Kostelano
Kostelano - comment - 29 Jan 2023

Language strings with such an implementation are poorly translated into other languages due to different declensions and, for example, it is also not customary to use capitalized words in the middle of a sentence. It's better to just use a variable as a reference.

Something like this:

This file is too large to upload. You can change the limits for your site in the <a href=\"%s\">Media component</a>.

Anticipating an objection, I will say that HTML is used all the time in language files.

avatar brianteeman
brianteeman - comment - 29 Jan 2023

It is a standard string construction used throughout Joomla. If you believe it is a bad structure for translators then please raise a new issue for that. It is beyond the scope of this PR.

de90fdd 29 Jan 2023 avatar brianteeman cs
avatar brianteeman brianteeman - change - 29 Jan 2023
Labels Added: Language Change PR-4.3-dev
avatar ChristineWk ChristineWk - test_item - 30 Jan 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 30 Jan 2023

I have tested this item successfully on de90fdd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39741.

avatar toivo toivo - test_item - 16 Feb 2023 - Tested successfully
avatar toivo
toivo - comment - 16 Feb 2023

I have tested this item successfully on 9c1425e

Tested successfully in Joomla 4.3.0-beta2-dev of 16 February.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39741.

avatar toivo
toivo - comment - 16 Feb 2023

What happened to @ChristineWk's earlier successful test result?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39741.

avatar toivo
toivo - comment - 16 Feb 2023

What happened to @ChristineWk's earlier successful test result?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39741.

avatar Quy Quy - alter_testresult - 16 Feb 2023 - ChristineWk: Tested successfully
avatar Quy Quy - change - 16 Feb 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39741.

avatar Quy Quy - change - 16 Feb 2023
Labels Added: ?
avatar obuisard obuisard - close - 17 Feb 2023
avatar obuisard obuisard - merge - 17 Feb 2023
avatar obuisard obuisard - change - 17 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-17 17:53:47
Closed_By obuisard
avatar obuisard
obuisard - comment - 17 Feb 2023

Thank you, Brian @brianteeman !

Add a Comment

Login with GitHub to post a comment