PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
28 Jan 2023

Summary of Changes

Removes the Ads link for TinyMCE.

Testing Instructions

Apply PR and active TinyMCE as default editor

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2023
Category Front End Plugins
avatar bembelimen bembelimen - open - 28 Jan 2023
avatar bembelimen bembelimen - change - 28 Jan 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 28 Jan 2023

What version of tinymce are you using? I have never seen that advert?

avatar brianteeman
brianteeman - comment - 28 Jan 2023

From what I can see in the docs this was added in Tinymce 6.2 while Joomla is using Tinymce 5.10

avatar laoneo
laoneo - comment - 28 Jan 2023

So this should go then into the 5 branch.

avatar brianteeman
brianteeman - comment - 28 Jan 2023

So this should go then into the 5 branch.

assuming I am correct and @bembelimen has somehow installed tiny6.2 on joomla 4.2

avatar toivo toivo - test_item - 16 Feb 2023 - Tested successfully
avatar toivo
toivo - comment - 16 Feb 2023

I have tested this item successfully on c81b53c

Tested successfully in Joomla 4.3.0-beta2-dev of 16 February.

Couldn't see any promotion/upgrade link in the TinyMCE edit box, neither before nor after the patch, but the Patch Tester inserted the additional line in the right place, as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39734.

avatar brianteeman
brianteeman - comment - 16 Feb 2023

@toivo That's not a succcessful test as you didn't observe the pull request hiding anything.

avatar toivo
toivo - comment - 16 Feb 2023

Ok, understood. I tried to install embelimen:4.3/tinymce-promotion but it is far too complicated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39734.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2023
Category Front End Plugins Administration com_admin SQL Postgresql com_associations
avatar bembelimen bembelimen - change - 23 Feb 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-02-23 13:09:28
Closed_By bembelimen
Labels Added: PR-4.3-dev
avatar bembelimen bembelimen - close - 23 Feb 2023
avatar bembelimen
bembelimen - comment - 23 Feb 2023

Update: #39920

Add a Comment

Login with GitHub to post a comment