[#39700] - remove unused variable
- Fixed in Code Base
- 3 Feb 2023
- Medium
- Build: 4.2-dev
- # 39700
- Diff
- chmst:contact-unused-variable
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Remove a copy/paste error.
com_contact does not use $_articles nor $_contacts,
As comment and variable name are different, this seems to be a copy/paste error.
Testing Instructions
Code review should be sufficient.
Or set error-reporting at maximum, play with contacts in frontend.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Contacts in fronted are displayed as without patch, no error, no warning.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39700.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39700.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-03 20:45:27 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
Always nice to see unused stuff removed. Thanks!
I have tested this item✅ successfully on cd0b658
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39700.