Information Required ? Pending

User tests: Successful: Unsuccessful:

avatar 2003tanmay
2003tanmay
22 Jan 2023

Pull Request for Issue #38443.

Summary of Changes

Replaced overflow-x:auto by overflow:visible rule on the <div class="table-responsive"> , it fixed the display of the calendar.

Testing Instructions

Create a calendar custom field.
Create a repeatable subform custom field.
Add the calendar field to the subform field. Save and close.

Open an article where you can edit the subform field and add some items.

Actual result BEFORE applying this Pull Request

184362896-e2af4357-b488-455e-9d08-0a8d9eac3d49.mov

Expected result AFTER applying this Pull Request

Screenshot (53)

Link to documentations

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2023
Category Layout
avatar 2003tanmay 2003tanmay - open - 22 Jan 2023
avatar 2003tanmay 2003tanmay - change - 22 Jan 2023
Status New Pending
avatar Quy Quy - change - 22 Jan 2023
The description was changed
avatar Quy Quy - edited - 22 Jan 2023
avatar richard67
richard67 - comment - 22 Jan 2023

It would be better to apply the style in an scss file. Inline styles are not good for a strict CSP (content security policy).

avatar crystalenka
crystalenka - comment - 22 Jan 2023

Please check what happens when you have multiple fields that would cause the table to overflow horizontally. The original rule was there to make tables responsive per Bootstrap styling; this could break tables in smaller screens iirc

avatar crystalenka crystalenka - test_item - 23 Jan 2023 - Tested unsuccessfully
avatar crystalenka
crystalenka - comment - 23 Jan 2023

I have tested this item ? unsuccessfully on a72bf6c

As I mentioned in my previous comment as well as in my original issue, this breaks the responsive functionality of tables. I wish it was such a simple solution, but it is not.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39694.

avatar crystalenka
crystalenka - comment - 23 Jan 2023

Screenshot of the broken table :(
Screenshot 2023-01-23 at 10 34 54

avatar 2003tanmay
2003tanmay - comment - 23 Jan 2023

Screenshot of the broken table :( Screenshot 2023-01-23 at 10 34 54

how can i reproduce this issue?

avatar Quy
Quy - comment - 23 Jan 2023
avatar Quy
Quy - comment - 27 Jan 2023

@2003tanmay Please consider closing if you don't have another solution as it breaks with multiple fields. Thanks for contributing.

avatar Quy
Quy - comment - 5 Feb 2023

Closing as this is not a proper fix for reasons stated. Use the new layout option from #38180 as a workaround. Thank you for your ocntribution.

avatar Quy Quy - close - 5 Feb 2023
avatar Quy Quy - change - 5 Feb 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-02-05 00:49:19
Closed_By Quy
Labels Added: Information Required ?

Add a Comment

Login with GitHub to post a comment