[#39691] - [4.2] Add missing properties
- Fixed in Code Base
- 11 Feb 2023
- Medium
- Build: 4.2-dev
- # 39691
- Diff
- joomdonation:dynamic_properties
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This simple PR adds missing properties to various classes in our libraries to avoid deprecated warning missing properties in PHP 8.2. These missing properties are detected automatically by rector CompleteDynamicPropertiesRector rule.
Testing Instructions
- Code review should be enough
- Or apply patch, installing extension and make sure it is still working OK.
Actual result BEFORE applying this Pull Request
Deprecated warnings when installing package extensions on PHP 8.2 and in some other places.
Expected result AFTER applying this Pull Request
No warnings anymore.
Link to documentations
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PHP 8.x
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39691.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39691.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39691.
The error variable needs to be deprecated then in 4.3 as it is probably a leftover in conjunction with CMSObject and not used anymore.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-11 13:14:39 |
| Closed_By | ⇒ | fancyFranci |
Thanks for fixing the warnings!
@joomdonation PHPCS complains about the new variable with the name beginning with an underscore here:
You can solve that by adding file "libraries/src/Installer/Manifest.php" to the list of allowed exceptions in the ruleset in this section: https://github.com/joomla/joomla-cms/blob/4.2-dev/ruleset.xml#L32 like it has been already done for file "libraries/src/Client/FtpClient.php", which is full of such variable names.