Feeling Lucky
?
Release Blocker
?
[#39676] - [bug] Missing variables
- Fixed in Code Base
- 20 Jan 2023
- Medium
- Build: 4.2-dev
- # 39676
- Diff
- dgrammatiko:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The error_login page needs also the $loginLogo and loginLogoAlt (check line 120), my bad!
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Release Blocker
?
|
||
Quy
- comment
- 20 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39676.
viocassel
- comment
- 20 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39676.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 20 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39676.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-20 17:40:03 |
| Closed_By | ⇒ | roland-d |
roland-d
- comment
- 20 Jan 2023
Thank you
Line 121, change to:
<?php echo HTMLHelper::_('image', $loginLogo, $loginLogoAlt, ['loading' => 'eager', 'decoding' => 'async'], false, 0); ?>Otherwise, it will output without the
alt=:<img src="http://localhost/joomla-cms-4.2-dev/media/templates/administrator/atum/images/logos/login.svg" logo>