[#39661] - Introduce an Ldap factory in the authentication plugin
- Fixed in Code Base
- 28 Jan 2023
- Medium
- Build: 4.3-dev
- # 39661
- Diff
- Digital-Peak:authentication/ldap/factory
User tests: Successful: Unsuccessful:
Summary of Changes
Introduces an Ldap factory in the authentication plugin for better testing capability. The existing test is moved to the integration test suite as it is not a unit test. A new unit test class is added as well and some smaller code cleanup like camel case variables.
This should only be considered after #39624 got merged.
Testing Instructions
Is covered by unit and integration test.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PR-4.3-dev
|
||
The changes already handle some of my TODOs after my PRs are accepted, so thanks for that :)
But when I try a login, I get:
Joomla\Plugin\Authentication\Ldap\Extension\Ldap::__construct(): Argument #1 ($factory) must be of type Joomla\Plugin\Authentication\Ldap\Factory\LdapFactoryInterface, Joomla\Event\Dispatcher given, called in /var/www/html/timo/joomla-cms-composed/plugins/authentication/ldap/services/provider.php on line 42
The tests succeed however. Can the register function of the provider be tested?
Somehow the changes got reverted in the provider file. Fixed that.
It's working now
obuisard
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-28 01:44:29 |
| Closed_By | ⇒ | obuisard |
@laoneo Could you include the configuration and documentation changes in #38775 ? The ldap tests are also moved to Integration there.