Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39652] - [4.3][bug] fix 5.2 + debug lang

? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
16 Jan 2023

Pull Request for Issue #39651 .

Summary of Changes

Testing Instructions

Check the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2023
Category ⇒ Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 16 Jan 2023
avatar dgrammatiko dgrammatiko - change - 16 Jan 2023
Status New ⇒ Pending
avatar heelc29
heelc29 - comment - 16 Jan 2023

warning is also possible

joomla-cms/build/media_source/plg_system_debug/widgets/languageFiles/widget.es5.js

Line 20 in 92c0149

var css = data.loaded[extension][file] ? 'alert-success' : 'alert-warning' 

<tr>
    <td>pkg_en-GB.sys</td>
    <td>
        <ul>
            <li class="alert-warning">- /language/en-GB/pkg_en-GB.sys.ini</li>
            <li class="alert-warning">- /language/en-GB/en-GB.pkg_en-GB.sys.ini</li>
        </ul>
    </td>
</tr>
avatar heelc29
heelc29 - comment - 16 Jan 2023

success works
image

avatar dgrammatiko dgrammatiko - change - 16 Jan 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar heelc29 heelc29 - test_item - 16 Jan 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 16 Jan 2023

I have tested this item ✅ successfully on d29ea2b

image

Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar Quy Quy - test_item - 16 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 16 Jan 2023

I have tested this item ✅ successfully on d29ea2b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar Quy Quy - change - 16 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 16 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar heelc29
heelc29 - comment - 17 Jan 2023

@dgrammatiko Should this code maybe added to plg_system_debug/widgets/languageFiles/widget.css instead of plg_system_debug/css/debug.css?

ba4e5ca 17 Jan 2023 avatar dgrammatiko move
avatar dgrammatiko dgrammatiko - change - 17 Jan 2023
Labels Added: ?
4ea06bb 17 Jan 2023 avatar dgrammatiko CS
avatar dgrammatiko
dgrammatiko - comment - 17 Jan 2023

@heelc29 yeah that seems the right place. I already moved the code there, thanks

avatar heelc29 heelc29 - test_item - 17 Jan 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 17 Jan 2023

I have tested this item ✅ successfully on 4ea06bb

Still works

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar richard67 richard67 - change - 17 Jan 2023
Status Ready to Commit ⇒ Pending
avatar richard67
richard67 - comment - 17 Jan 2023

Back to pending. One more human test needed.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar Quy Quy - test_item - 17 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 17 Jan 2023

I have tested this item ✅ successfully on 4ea06bb

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar Quy Quy - change - 17 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 17 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652.

avatar obuisard obuisard - close - 19 Jan 2023
avatar obuisard obuisard - merge - 19 Jan 2023
avatar obuisard obuisard - change - 19 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-19 01:26:20
Closed_By ⇒ obuisard
avatar obuisard
obuisard - comment - 19 Jan 2023

Thank you Dimitris @dgrammatiko for the fix!

Add a Comment

Login with GitHub to post a comment