? PHP 8.x ?
avatar laoneo
laoneo
11 Jan 2023

Summary of Changes

Define the threshold property in the CacheStorage class to prevent deprecation notice on PHP 8.2.
This must be tested by code review as it only happens when I want to install the DPCalendar sample data. But it is pretty obvious.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 11 Jan 2023
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2023
Category Libraries
avatar laoneo laoneo - change - 11 Jan 2023
Labels Added: PHP 8.x
avatar joomdonation
joomdonation - comment - 11 Jan 2023

OK now but there is no Test this button in issue tracker to report test result for some reasons.

avatar carlitorweb
carlitorweb - comment - 12 Jan 2023

@laoneo this deprecation notice also show in the articles view
articlesview

avatar laoneo laoneo - change - 12 Jan 2023
Labels Added: ?
avatar laoneo
laoneo - comment - 12 Jan 2023

I know, it is almost on every page where the cache is used. @carlitorweb did you test it successfully? Then I would set it to RTC as well as @joomdonation couldn't mark his result in the tracker.

avatar carlitorweb
carlitorweb - comment - 12 Jan 2023

Me either @laoneo , the button not was there.
But yes, test successfully

avatar laoneo laoneo - change - 12 Jan 2023
Status New Ready to Commit
avatar laoneo
laoneo - comment - 12 Jan 2023

Setting RTC as we have two tests.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39604.

avatar laoneo laoneo - change - 12 Jan 2023
Labels Added: ?
avatar HLeithner HLeithner - change - 12 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-12 15:54:34
Closed_By HLeithner
avatar HLeithner HLeithner - close - 12 Jan 2023
avatar HLeithner HLeithner - merge - 12 Jan 2023
avatar HLeithner
HLeithner - comment - 12 Jan 2023

thanks

Add a Comment

Login with GitHub to post a comment