? PHP 8.x ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
11 Jan 2023

Summary of Changes

Define the tags property in the TagsHelper class to prevent deprecation notice on PHP 8.2.

Testing Instructions

Open the article form on the PHP 8.2 on the front end with debug enabled.

Actual result BEFORE applying this Pull Request

The following warning is shown:
Creation of dynamic property Joomla\CMS\Helper\TagsHelper::$tags is deprecated in

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2023
Category Libraries
avatar laoneo laoneo - open - 11 Jan 2023
avatar laoneo laoneo - change - 11 Jan 2023
Status New Pending
avatar alikon alikon - test_item - 11 Jan 2023 - Tested successfully
avatar alikon
alikon - comment - 11 Jan 2023

I have tested this item successfully on 263bbdd

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39600.

07ae895 11 Jan 2023 avatar laoneo doc
avatar laoneo laoneo - change - 11 Jan 2023
Labels Added: PHP 8.x
avatar joomdonation joomdonation - test_item - 11 Jan 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 11 Jan 2023

I have tested this item successfully on 07ae895


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39600.

avatar joomdonation joomdonation - alter_testresult - 11 Jan 2023 - alikon: Tested successfully
avatar joomdonation joomdonation - change - 11 Jan 2023
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 11 Jan 2023

I restored @alikon's test result because the last change is just a docblock change. RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39600.

avatar laoneo laoneo - change - 11 Jan 2023
Labels Added: ?
avatar roland-d roland-d - change - 11 Jan 2023
Labels Added: ?
avatar roland-d roland-d - close - 11 Jan 2023
avatar roland-d roland-d - merge - 11 Jan 2023
avatar roland-d roland-d - change - 11 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-11 19:42:54
Closed_By roland-d
avatar roland-d
roland-d - comment - 11 Jan 2023

Thank you

Add a Comment

Login with GitHub to post a comment