? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
10 Jan 2023

Pull Request for Issue #39584 .

Summary of Changes

Changed the name of the styles for the web assets manager to avoid overwriting if several modules are present on a page.

Testing Instructions

Create two newsflash modules, one with horizontal and one with vertical layout.
See issue for more details.

Actual result BEFORE applying this Pull Request

If the vertical layout is loaded as latest the module with the horizontal layout will be also displayed as vertical, because the css is missing.

Expected result AFTER applying this Pull Request

Horizontal layout won't be overwritten by the vertical module.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2023
Category Modules Front End
avatar drmenzelit drmenzelit - open - 10 Jan 2023
avatar drmenzelit drmenzelit - change - 10 Jan 2023
Status New Pending
avatar brianteeman brianteeman - test_item - 10 Jan 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Jan 2023

I have tested this item successfully on 010470b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39585.

avatar chmst chmst - test_item - 10 Jan 2023 - Tested successfully
avatar chmst
chmst - comment - 10 Jan 2023

I have tested this item successfully on 010470b

Code Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39585.

avatar chmst chmst - change - 10 Jan 2023
Status Pending Ready to Commit
avatar chmst
chmst - comment - 10 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39585.

avatar roland-d roland-d - change - 10 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-10 18:06:44
Closed_By roland-d
Labels Added: ? ?
avatar roland-d roland-d - close - 10 Jan 2023
avatar roland-d roland-d - merge - 10 Jan 2023
avatar roland-d
roland-d - comment - 10 Jan 2023

Thank you

avatar drmenzelit
drmenzelit - comment - 10 Jan 2023

Thanks!

Add a Comment

Login with GitHub to post a comment