[#39579] - [4.2] Clean the logo URL in Atum
- Fixed in Code Base
- 9 Jan 2023
- Medium
- Build: 4.2-dev
- # 39579
- Diff
- dgrammatiko:4.2-dev-atum-logo
User tests: Successful: Unsuccessful:
Pull Request is the same bug fix as #39574
Summary of Changes
Use the recommended way to render an image: through the HTMLHelper
Testing Instructions
Check that selecting a custom logo image works and that the source doesn't have the hash part of the URL. Also check that svg renders as expected
Actual result BEFORE applying this Pull Request
The URL contains the hash (it is dirty) and SVG images get 0 width and height thus are not visible
Expected result AFTER applying this Pull Request
The URL does not contain the hash (it is clean) and SVG images are visible
Link to documentations
This is a bug fix without changing any of the existing functionality
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39579.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39579.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-09 15:37:26 |
| Closed_By | ⇒ | roland-d |
Thank you
I have tested this item✅ successfully on 53821a0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39579.