[#39561] - Login feedback if user do not have offline access
- Fixed in Code Base
- 26 Feb 2023
- Medium
- Build: 4.2-dev
- # 39561
- Diff
- carlitorweb:4.2/issue/39559/no_offline_access_feedback
User tests: Successful: Unsuccessful:
Pull Request for Issue #39559
I used the core string JLIB_LOGIN_DENIED = Your access has been denied. But I think we should create a new one just for this message
Summary of Changes
PlgAuthenticationJoomla verified is a valid user who try to access, but not check the permission of the offline mode.
Testing Instructions
Set your site in offline mode. Go to the frontend and try login with a user who have the permission Offline Access = Not allowed
Actual result BEFORE applying this Pull Request
The user cant login, but not message show up of why cant login
Expected result AFTER applying this Pull Request
The user cant login, but a message show up of why cant login
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
@richard67 For API dont matter. Right now, an unique Bearer token or credentials need be provided in the request. The later have his own separate routine for authenticate the user Joomla\Plugin\ApiAuthentication\Basic\Extension\Basic (by the way is almost the same as PlgAuthenticationJoomla)
I did not interact much with the CLI yet, but I tested for example, when offline the site I could add a new user trought the CLI without problem. I not think so far this change affect the CLI application. Anyway, let me kown if anything need be changed.
| Labels |
Added:
?
|
||
@richard67 can you run the drone again, not sure why fail
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39561.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39561.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39561.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-26 19:57:47 |
| Closed_By | ⇒ | fancyFranci |
Thank you for making it easier for the users!
@carlitorweb As the check added by this PR is in the
elsepart of an$this->app->isClient('administrator')check, it doesn't only apply to the site but also to other non-admin clients like api and cli. Is that intended?