[#39550] - Fix PluginHelper::getLayoutPath to work in non Web context, like Cli, Api
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.2-dev
- # 39550
- Diff
- Fedik:fix-plg-layout-cli
User tests: Successful: Unsuccessful:
Fix for stuff like #38222 and #38214 .
Summary of Changes
Prevent crashing of plugin renderers in non Web context
Testing Instructions
Have to apply all PR, this one, then #38585 then #38650
Then run test from #38650
Actual result BEFORE applying this Pull Request
Error
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Have you mixed up actual and expected result in the description?
Yeap, that was me
For next tester, to reproduce the error go to the terminal and type: php cli/joomla.php finder:index
As result you will get:
I not sure if through the administrator the mass indexer in the smart search component need throw an error, was not my case.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550.
This pull request has been automatically rebased to 4.3-dev.
| Labels |
Added:
?
bug
|
||
| Labels |
Added:
PR-4.3-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 18:36:51 |
| Closed_By | ⇒ | obuisard |
I think
PluginHelper::getLayoutPathwe should deprecate to remove in 6.x, in favor of uselayout