Feeling Lucky
?
PR-4.3-dev
[#39539] - Convert mod_articles_popular to new structure
- Closed
- 12 Jan 2023
- Medium
- Build: 4.3-dev
- Easy Test
- # 39539
- Diff
- carlitorweb:convert_mod_articles_popular
User tests: Successful: Unsuccessful:
Summary of Changes
This PR converts mod_articles_popular to the new structure
Testing Instructions
- Use Joomla 4.3
- Create an instance of the module Articles - Most Read. Note how it works.
- Apply patch
- Delete administrator/cache/autoload_psr4.php
- Refresh the page, make sure the module still displays the same as before.
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
chmst
- comment
- 3 Jan 2023
@carlitorweb my apologies, was not intended to remove the label.
chmst
- comment
- 6 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539.
viocassel
- comment
- 9 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
Quy
- comment
- 9 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539.
| Labels |
Added:
?
|
||
laoneo
- comment
- 10 Jan 2023
I would like to avoid static functions, so I made some suggestions. Can you please review them @carlitorweb ?
laoneo
- comment
- 12 Jan 2023
Can we get here just one more test to ensure the recent cosmetic changes are correct?
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-12 16:02:03 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 12 Jan 2023
thanks
@chmst I using the wrong branch?