[#39537] - [4.3] Migrate most components to the new toolbar api
- Fixed in Code Base
- 21 Jan 2023
- Medium
- Build: 4.3-dev
- # 39537
- Diff
- wilsonge:cache_toolbar_api
User tests: Successful: Unsuccessful:
Summary of Changes
Migrate the majority of core components towards the new toolbar API (notably I'm skipping Joomla Update as part of this PR and the use of ToolbarHelper::modal in com_templates views which probably need to be moved to the popupButton - but that's a bigger piece of work for another PR)
Testing Instructions
Check all the toolbar icons work the same before and after the patch is applied across all backend components
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_cache |
| Status | New | ⇒ | Pending |
https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Toolbar/ToolbarButton.php#L221
IDs look fairly fixed. I can rebase this to 5.0 I guess - Depends how much we think IDs are a major b/c break in the backend. It's only the delete button that has the changed ID right?
changes the button id :(
@brianteeman: I see where you come from, but, TBH, Im not entirely sure if thats desired direction.......
| Category | Administration com_cache | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact com_content com_contenthistory com_cpanel com_fields com_finder |
| Labels |
Added:
PR-4.3-dev
|
||
| Title |
|
||||||
| Title |
|
||||||
Yes. Sorry originally the PR was just over com_cache but then I worked on some more components so need to update the instructions
Final batch of components migrated. I suggest we test functionality here and I'll leave it to @joomla/cms-maintainers to decide if it needs to go to 4.3 or 5.0 and I'll happily rebase it to 5.0 if the IDs are deemed a concern.
- com_actionlogs
✔️ - com_admin
✔️ - com_associations
✔️ - com_cache
✔️ - com_categories
✔️ - com_checkin
✔️ - com_config
✔️ - com_contact
✔️ - com_cpanel
✔️ - com_content
✔️ - com_contenthistory
✔️ - com_fields
✔️ - com_finder
✔️ - com_installer
✔️ - com_languages
✔️ - com_media
✔️ - com_menus
✔️ - com_messages
✔️ - com_modules
✔️ - com_newsfeed
✔️ - com_plugins
✔️ - com_postinstall
✔️ - com_privacy
✔️ - com_redirect
✔️ - com_sheduler
✔️ - com_tags
✔️ - com_templates
✔️ - com_users
✔️ - com_workflow
✔️
@carlitorweb also got this error
Fixed!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537.
Is there a reason why you not directly migrate this to ListView and FormView, also Toolbar::getInstance(); is deprecated so I think you are not allowed to introduce new deprecated function calls ;-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537.
Is there a reason why you not directly migrate this to ListView and FormView, also Toolbar::getInstance(); is deprecated so I think you are not allowed to introduce new deprecated function calls ;-)
Not all of these views are ready to be migrated - but having everything consistently using the toolbar api as an example to extension devs is a good thing. The new API is also easier to understand than many of the magic parameters we currently have. I had to spend ages figuring out some of the mappings
Toolbar::getInstance removal is a major deal. The factory being stored in the container means that there's no way to share it with the module. I suspect that's a major version change.
Not all of these views are ready to be migrated
But shouldn't we move the one we can to the two mentioned views (+ updating them, too): It would save so much code.
But shouldn't we move the one we can to the two mentioned views (+ updating them, too): It would save so much code.
Eventually yes. But I don't think we are ready yet. Certainly aligning the views first so that jump is smaller isn't a bad thing anyhow
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-21 04:17:47 |
| Closed_By | ⇒ | obuisard |
I have tested this item? unsuccessfully on b4bab7d
changes the button id :(
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537.