Language Change bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Dec 2022

I was wrong and should have listened more to what @HLeithner was saying. He was obviously correct that you can't use &hellip, in a language string in the cli.

I still think the lack of readability of using utf characters in a search string is an issue so I have reverted the use to ...

I have also reviewed all the other changes that I made in that PR and instead of reverting I am removing the … as it really served no purpose or was being misused.

As far as I can see now the remaining uses from that PR all relate to Read more where I still believe it is best to use &hellip but I would be happy to revert those as well.

As far as I can tell the only remaining instance of ... is in the truncate functions where I believe it is correct

Sorry for causing this issue.

I am not sure if we are in a freeze for strings in 4.2 so if required I can rebase to 4.3

7a845df 30 Dec 2022 avatar brianteeman push
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2022
Category Administration Language & Strings Installation
avatar brianteeman brianteeman - open - 30 Dec 2022
avatar brianteeman brianteeman - change - 30 Dec 2022
Status New Pending
avatar brianteeman brianteeman - change - 31 Dec 2022
Labels Added: Language Change ?
avatar HLeithner
HLeithner - comment - 31 Dec 2022

Thanks for creating this pr, do you really think that "please help" without the … is better?

I personal would be more happy remove all html encoded entries where possible.

avatar brianteeman
brianteeman - comment - 31 Dec 2022

Thanks for creating this pr, do you really think that "please help" without the … is better?

did you mean "please wait ..."
If you did then yes I dont see it as needed. We're not using it to indicate there is more text that has been truncated but to indicate that something is happening. Which it doesnt actually do as its a static text

I personal would be more happy remove all html encoded entries where possible.

The theory I was trying to adopt with this change was that &hellip is good but lets keep it just for indicating truncation and limited to things that will only be consumed in html eg "read more ..."

but as it was my f - up. I am happy to simply revert completely

avatar HLeithner
HLeithner - comment - 31 Dec 2022

consistent would be better, so if you would be so kind remove all html encodings. and we don't use it for "there will something happen"

avatar brianteeman
brianteeman - comment - 31 Dec 2022

ok - will do

avatar brianteeman brianteeman - change - 31 Dec 2022
The description was changed
avatar brianteeman brianteeman - edited - 31 Dec 2022
avatar brianteeman
brianteeman - comment - 31 Dec 2022

@HLeithner updated the original post with current status (will update the styleguide when this is merged)

Note: there are a lot of instance of &quot &rarr etc

avatar HLeithner
HLeithner - comment - 1 Jan 2023

replacing &qoute blindly could be a problem because I wouldn't swear that the cms escapes it everywhere correctly,
&rarr should be no problem to replace it with → same for &larr with ← if we have any …

avatar brianteeman
brianteeman - comment - 1 Jan 2023

yes I wouldnt want to do it blindly and it will probably need to be replaced by "

&rarr, &larr, &lt, &gt should all be safe to change.

Do you want me to do it in this PR or seperate pr for each type

avatar HLeithner
HLeithner - comment - 1 Jan 2023

I think one pr would ok for all this changes can be tested at once I think

avatar brianteeman
brianteeman - comment - 1 Jan 2023

changed to draft while I update the other html characterss

avatar brianteeman
brianteeman - comment - 2 Jan 2023

@HLeithner I'm not sure about the &lt, &gt changes. I cant seem to find a way to escape the <

avatar HLeithner
HLeithner - comment - 2 Jan 2023

hmm &lt and &gt is a problem, because if we don't use it we have valid html control characters, I would keep them. Also because we mix real html in the language strings.

avatar chmst
chmst - comment - 1 Mar 2023

Looks good for me. Just had one of these strange … messages
@brianteeman could you remove the state draft?

@HLeithner I think it is better to get merge this one for now - if necessary we can improve it then. Or do you see problems?

avatar Quy Quy - test_item - 2 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 2 Mar 2023

I have tested this item successfully on 53411ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39528.

avatar coolcat-creations
coolcat-creations - comment - 21 Apr 2023

How to test this?

avatar brianteeman
brianteeman - comment - 21 Apr 2023

go to any of the changed strings in the CMS and check that you are seeing the correct characters eg when it said &rarr you have a right arrow

avatar coolcat-creations
coolcat-creations - comment - 21 Apr 2023

Ok but before applying the patch I see an arrow and after also, Is this a problem in specific browsers?

avatar brianteeman
brianteeman - comment - 21 Apr 2023

that is a success.

the problem with the change from arrows etc to html characters which this PR reverts was that it did not work in the cli

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar brianteeman brianteeman - close - 8 Sep 2023
avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-08 12:01:49
Closed_By brianteeman
Labels Added: bug PR-4.3-dev
Removed: ?

Add a Comment

Login with GitHub to post a comment