No Code Attached Yet PHP 8.x bug
avatar ReLater
ReLater
28 Dec 2022

Steps to reproduce the issue

  • I'm using Bearsampp, Win10 Pro, PHP8.2, Joomla 4.2.6. I wasn't aware that XDebug is activated in Bearsampp (and I don't know how to turn it off at the moment) ;-) So I needed a while to understand what is happening.

  • XDebug is throwing a deprected message

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in libraries\vendor\voku\portable-utf8\src\voku\helper\UTF8.php on line 4653

  • which crashes front-end and back-end afterwards with error message

Failed to start the session because headers have already been sent by "libraries\vendor\voku\portable-utf8\src\voku\helper\UTF8.php" at line 4653.

Replacing all ${chars} with {$chars} in UTF8.php solved the issue. But it's a vendor library where Joomla or whatever is loading v5.4.51 where this PHP82 fix is not included: voku/portable-utf8#181 (v6.0.?).

avatar ReLater ReLater - open - 28 Dec 2022
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 28 Dec 2022
avatar ReLater ReLater - change - 28 Dec 2022
The description was changed
avatar ReLater ReLater - edited - 28 Dec 2022
avatar wilsonge
wilsonge - comment - 29 Dec 2022

wamania/php-stemmer#26 Looks like it's going to be tricky because this compat release is going to require a higher library version. @zero-24 we might need to put something in joomla-backports

avatar zero-24
zero-24 - comment - 29 Dec 2022

Looks like @SharkyKZ already raised that with the maintainers, lets see how they react. Not happy to branch it out just for such a non reason but please let me know as soon as you notice that a decision is taken on that topic by them and I can create a repo on joomla-backports when we do need it.

avatar SharkyKZ
SharkyKZ - comment - 29 Dec 2022

FWIW, it already requires PHP 7.3 since 3.0. Although that's only because of a bump in phpunit dev dependency. There have been no code changes so it's still very much PHP 7.0 compatible.

avatar brianteeman
brianteeman - comment - 29 Dec 2022
avatar laoneo laoneo - change - 12 Jan 2023
Labels Added: PHP 8.x
avatar laoneo laoneo - labeled - 12 Jan 2023
avatar Hackwar Hackwar - change - 22 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 22 Feb 2023
avatar Hackwar
Hackwar - comment - 27 Feb 2023

I asked @wamania if he could do a new release: wamania/php-stemmer#30

avatar Hackwar
Hackwar - comment - 27 Feb 2023

And there actually already is a PR for this: wamania/php-stemmer#26

avatar Hackwar Hackwar - change - 27 Feb 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-02-27 13:10:14
Closed_By Hackwar
avatar Hackwar Hackwar - close - 27 Feb 2023
avatar Hackwar
Hackwar - comment - 27 Feb 2023

And the fix for us is here: #39955
Please test this PR and I'm closing this issue.

Add a Comment

Login with GitHub to post a comment