Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39508] - [4.2.6] Email cloaking fails.

? Release Blocker ? Pending

User tests: Successful: Unsuccessful:

avatar LukasHH
LukasHH
27 Dec 2022

Pull Request for Issue #39422 .

Summary of Changes

a) modification of the last pattern
b) added more patterns

Testing Instructions

create article with

for the last pattern:

<img class="img-thumbnail" style="border: 1px solid #00f;" title="email@example.org" src="/www/j4test/images/joomla_black.png" alt="" />
<input type="text" placeholder="email@example.org" />

for the new pattern (email as plain text within html-attributes):

<a class="btn btn-danger" style="border: 2px solid #f00;" title="email@example.org" href="#">email</a>
<a title="email@example.org" href="#">email</a>
<ul>
<li title="email-1@example.org">email 1</li>
<li title="email-2@example.org">email 2</li>
</ul>

for the new last pattern (email as plain text but not within HTML tags):

<span>email--1@example.org</span>
<ul>
<li>email-0@example.org</li>
<li>email-1@example.org</li>
</ul>

Actual result BEFORE applying this Pull Request

a) the pattern was too hungry
b) emails as plain text within html-attributes and not within html-tags was not cloaked

Expected result AFTER applying this Pull Request

a) the pattern was not too hungry
b) emails as plain text within html-attributes and not within html-tags was cloaked

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2022
Category ⇒ Front End Plugins
avatar LukasHH LukasHH - open - 27 Dec 2022
avatar LukasHH LukasHH - change - 27 Dec 2022
Status New ⇒ Pending
avatar LukasHH LukasHH - change - 27 Dec 2022
The description was changed
avatar LukasHH LukasHH - edited - 27 Dec 2022
avatar LukasHH LukasHH - change - 27 Dec 2022
Labels Added: ?
avatar LukasHH LukasHH - change - 27 Dec 2022
Title
…
[4.2.6] Email cloaking fails. (#39336)
[4.2.6] Email cloaking fails.
avatar LukasHH LukasHH - edited - 27 Dec 2022
avatar ReLater ReLater - test_item - 28 Dec 2022 - Tested successfully
avatar ReLater
ReLater - comment - 28 Dec 2022

I have tested this item ✅ successfully on c29f7b0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39508.

Tested with this horrible HTML code:


<h1>Start</h1>

<p><a href="http://mce_host/ourdirectory/email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">email@example.org</a></p>
<p><a href="http://mce_host/ourdirectory/email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">anytext</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">email@example.org</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">email@example.org</span></a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">anytext</span></a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">anytext</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" /></a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />email@example.org</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />any text</a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;">email@example.org</a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;">anytext</a></p>
<p><a href="mailto:email@example.org?subject= Text" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">email@example.org</span></a></p>
<p><a href="mailto:email@example.org?subject= Text" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">anytext</span></a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" /></a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />email@example.org</a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />any text</a></p>
<p><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" title="email@example.org" /></p>
<p><input type="text" placeholder="email@example.org" /></p>

<p>email@example.org</p>

<span>email--1@example.org</span>
<ul>
<li>email-0@example.org</li>
<li>email-1@example.org</li>
</ul>

<a class="btn btn-danger" style="border: 2px solid #f00;" title="email@example.org" href="#">email</a>
<a title="email@example.org" href="#">email</a>
<ul>
<li title="email-1@example.org">email 1</li>
<li title="email-2@example.org">email 2</li>
</ul>

<img class="img-thumbnail" style="border: 1px solid #00f;" title="email@example.org" src="images/joomla_black.png" alt="" />
<input type="text" placeholder="email@example.org" />

<h1>End</h1>

If JS off: No readable email address on page. All masqueraded with This email address is being protected from spambots. You need JavaScript enabled to view it.

avatar LukasHH LukasHH - change - 28 Dec 2022
Labels Added: Release Blocker
avatar viocassel viocassel - test_item - 28 Dec 2022 - Tested successfully
avatar viocassel
viocassel - comment - 28 Dec 2022

I have tested this item ✅ successfully on cec7414

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39508.

avatar richard67 richard67 - alter_testresult - 28 Dec 2022 - ReLater: Tested successfully
avatar richard67
richard67 - comment - 28 Dec 2022

I've restored @ReLater 's test result since the 2 commits after that were just clean branch updates.

@LukasHH Please avoid unnecessary branch updates because they invalidate the human tests counter and so make it harder for us to find pull requests which should be set to ready to commit (RTC) when they have 2 successful human tests.

avatar richard67 richard67 - edited - 28 Dec 2022
avatar richard67 richard67 - change - 28 Dec 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 28 Dec 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39508.

avatar roland-d roland-d - change - 29 Dec 2022
Labels Added: ?
avatar roland-d roland-d - change - 29 Dec 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-12-29 09:47:22
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 29 Dec 2022
avatar roland-d roland-d - merge - 29 Dec 2022
avatar roland-d
roland-d - comment - 29 Dec 2022

Thank you

Add a Comment

Login with GitHub to post a comment