? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
22 Dec 2022

Summary of Changes

It is not necessary that cypress.config.js is included in the package

Testing Instructions

Check if prebuilt packages contain the mentioned file

Actual result BEFORE applying this Pull Request

Joomla! 4.3 Nightly Builds
image

Expected result AFTER applying this Pull Request

Prebuilt package of this Pull Request
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@richard67 Is it necessary to add this file to com_admin/script.php since alpha1 has already been released?

avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2022
Category Repository
avatar heelc29 heelc29 - open - 22 Dec 2022
avatar heelc29 heelc29 - change - 22 Dec 2022
Status New Pending
avatar heelc29 heelc29 - change - 22 Dec 2022
The description was changed
avatar heelc29 heelc29 - edited - 22 Dec 2022
avatar richard67
richard67 - comment - 22 Dec 2022

@richard67 Is it necessary to add this file to com_admin/script.php since alpha1 has already been released?

@heelc29 Yes, but not with this pull request. I care for that, and I regularly do that after the relevant pull requests have been merged and before the release after that with use of a tool.

avatar brianteeman
brianteeman - comment - 22 Dec 2022

@richard67 not this time. the pull request is correct

avatar brianteeman brianteeman - test_item - 22 Dec 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Dec 2022

I have tested this item successfully on 253e343


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

avatar richard67
richard67 - comment - 22 Dec 2022

@richard67 not this time. the pull request is correct

@brianteeman I haven’t said the pull request is not correct. I have only said there is no need to care about deleted files in script.php because I will do that. My tool will show me if there is something to be done or not.

avatar brianteeman
brianteeman - comment - 22 Dec 2022

sorry @richard67 missed that part

avatar heelc29 heelc29 - change - 23 Dec 2022
The description was changed
avatar heelc29 heelc29 - edited - 23 Dec 2022
avatar ReLater ReLater - test_item - 24 Dec 2022 - Tested successfully
avatar ReLater
ReLater - comment - 24 Dec 2022

I have tested this item successfully on 253e343


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

avatar richard67 richard67 - change - 24 Dec 2022
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar richard67
richard67 - comment - 24 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

avatar richard67
richard67 - comment - 24 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

avatar wilsonge wilsonge - change - 24 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-24 20:21:46
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Dec 2022
avatar wilsonge wilsonge - merge - 24 Dec 2022

Add a Comment

Login with GitHub to post a comment